Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substr() with negative values does not work in IE < 9 #5

Closed
ericf opened this issue Mar 9, 2015 · 0 comments
Closed

substr() with negative values does not work in IE < 9 #5

ericf opened this issue Mar 9, 2015 · 0 comments

Comments

@ericf
Copy link

ericf commented Mar 9, 2015

IE < 9 does not support calling substr() with negative values, this makes the functions produced by this package unusable in older versions of IE.

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr#Polyfill
ericf added a commit to ericf/make-plural.js that referenced this issue Mar 9, 2015
@ericf
Replace substr() with substring() for IE < 9
d64fe56 
This replaces the use of `substr()` in the generated functions with
`substring()` calls because in IE < 9 calling `substr()` with a
negative value is not supported.

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr#Polyfill

Fixes eemeli#5
This was referenced Mar 9, 2015
Closed
Merged
@eemeli eemeli closed this as completed in f2564e0 Mar 9, 2015
ericf added a commit to formatjs/formatjs-extract-cldr-data that referenced this issue Mar 9, 2015
@ericf
Upgrade make-plural to fix plural fns in IE < 9
5a3fb5c 
This upgrades to make-plural@2.1.3 which fixes eemeli/make-plural#5
longlho pushed a commit to formatjs/formatjs-old that referenced this issue May 15, 2019
@ericf @longlho
Upgrade make-plural to fix plural fns in IE < 9
3bab5ba 
This upgrades to make-plural@2.1.3 which fixes eemeli/make-plural#5
longlho pushed a commit to formatjs/formatjs that referenced this issue Apr 27, 2020
@ericf @longlho
Upgrade make-plural to fix plural fns in IE < 9
cc1d4d7 
This upgrades to make-plural@2.1.3 which fixes eemeli/make-plural#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace substr() with substring() for IE < 9 ericf/make-plural.js
1 participant
@ericf