Remove DevelopmentDependency so package restores as expected #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-reynolds
added a commit
that referenced
this pull request
Aug 17, 2021
## [5.0.3-beta006] - 2021-08-17 ### Fixed - Removed `DevelopmentDependency=true` as it was setting `IncludeAssets` to undesirable values when restoring package - #108 - Fix formatting of Nullable parameters - [@LiteracyFanatic](https://github.com/LiteracyFanatic) - #106 - Handle nullablility correctly in snapshot generation - #107 - Issues with scaffolded code - Improved code generation for contexts scaffolded from an existing database - #89 - Correct issue with InsertData operations and 2D arrays - Generate valid code in HasData method - Fix issue with generated DbContext members in scaffolded code - Resolved issue with migrations have a missing unit arg to the Up method if no changes in model - Foreign Key constraints now created correctly - Fix indentation issue when table has constraints - #75 - Constraints now correctly generated - #72 - Generated Migrations will now always include the System namespace - #70 - Issues with scaffolded code - Improved code generation for contexts scaffolded from an existing database - #89 - Correct issue with InsertData operations and 2D arrays - Generate valid code in HasData method - Fix issue with generated DbContext members in scaffolded code - Resolved issue with migrations have a missing unit arg to the Up method if no changes in model - Foreign Key constraints now created correctly - Fix indentation issue when table has constraints - #75 - Constraints now correctly generated - #72 - Generated Migrations will now always include the System namespace - #70 [Unreleased]: v5.0.3-beta005...HEAD [5.0.3-beta005]: https://github.com/efcore/EFCore.FSharp/releases/tag/v5.0.3-beta005 ### Added - Single case union support - [@lucasteles](https://github.com/lucasteles) - #98 - Query translation for Option types - [@lucasteles](https://github.com/lucasteles) - #93 - DbSet/IQueryable helpers to deal with EF Core async and nullable methods - [@lucasteles](https://github.com/lucasteles) - #94 - Automatic registration of DesignTimeServices - #86 - DbContextHelpers - curried functions for interacting with DbContext to allow for a more 'native' F# experience - Single case union support - [@lucasteles](https://github.com/lucasteles) - #98 - Query translation for Option types - [@lucasteles](https://github.com/lucasteles) - #93 - DbSet/IQueryable helpers to deal with EF Core async and nullable methods - [@lucasteles](https://github.com/lucasteles) - #94 - Automatic registration of DesignTimeServices - #86 - DbContextHelpers - curried functions for interacting with DbContext to allow for a more 'native' F# experience
1 task
simon-reynolds
added a commit
that referenced
this pull request
Oct 16, 2021
## [5.0.3] - 2021-10-16 - Translations for `isNull` to be evaluated in-database - #114 ### Fixed - Removed `DevelopmentDependency=true` as it was setting `IncludeAssets` to undesirable values when restoring package - #108 - Fix formatting of Nullable parameters - [@LiteracyFanatic](https://github.com/LiteracyFanatic) - #106 - Handle nullablility correctly in snapshot generation - #107 - Issues with scaffolded code - Improved code generation for contexts scaffolded from an existing database - #89 - Correct issue with InsertData operations and 2D arrays - Generate valid code in HasData method - Fix issue with generated DbContext members in scaffolded code - Resolved issue with migrations have a missing unit arg to the Up method if no changes in model - Foreign Key constraints now created correctly - Fix indentation issue when table has constraints - #75 - Constraints now correctly generated - #72 - Generated Migrations will now always include the System namespace - #70 - Issues with scaffolded code - Improved code generation for contexts scaffolded from an existing database - #89 - Correct issue with InsertData operations and 2D arrays - Generate valid code in HasData method - Fix issue with generated DbContext members in scaffolded code - Resolved issue with migrations have a missing unit arg to the Up method if no changes in model - Foreign Key constraints now created correctly - Fix indentation issue when table has constraints - #75 - Constraints now correctly generated - #72 - Generated Migrations will now always include the System namespace - #70 [Unreleased]: v5.0.3-beta005...HEAD [5.0.3-beta005]: https://github.com/efcore/EFCore.FSharp/releases/tag/v5.0.3-beta005 ### Added - Single case union support - [@lucasteles](https://github.com/lucasteles) - #98 - Query translation for Option types - [@lucasteles](https://github.com/lucasteles) - #93 - DbSet/IQueryable helpers to deal with EF Core async and nullable methods - [@lucasteles](https://github.com/lucasteles) - #94 - Automatic registration of DesignTimeServices - #86 - DbContextHelpers - curried functions for interacting with DbContext to allow for a more 'native' F# experience - Single case union support - [@lucasteles](https://github.com/lucasteles) - #98 - Query translation for Option types - [@lucasteles](https://github.com/lucasteles) - #93 - DbSet/IQueryable helpers to deal with EF Core async and nullable methods - [@lucasteles](https://github.com/lucasteles) - #94 - Automatic registration of DesignTimeServices - #86 - DbContextHelpers - curried functions for interacting with DbContext to allow for a more 'native' F# experience
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removed
DevelopmentDependency=trueas it was settingIncludeAssetsto undesirable values when restoring packageTypes of changes
What types of changes does your code introduce to EFCore.FSharp?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...