Stdlib: Add OneOrBoth and zipLongest on lists and streams
#1003
Conversation
jiribenes
left a comment
jiribenes
left a comment
There was a problem hiding this comment.
The code is, I think, perfectly fine, but:
🚲, I really like Unison's names for these operations :)
libraries/common/list.effekt
Outdated
| /// ``` | ||
| /// | ||
| /// O(N) | ||
| def zipLongest[A, B](left: List[A], right: List[B]): List[These[A, B]] = { |
There was a problem hiding this comment.
Bikeshed: Unison calls this align which is a bit nicer, perhaps?
(ditto for streams)
There was a problem hiding this comment.
Here I care more about the name. Honestly, I would not search for this under the name align and don't quite get how this describes the operation well. align is a single word, but I fail to see how this fits the semantics uniquely.
There was a problem hiding this comment.
Funnily enough align is the name used in Haskell :D
https://hackage.haskell.org/package/semialign-1.3.1/docs/Data-Align.html#v:align
There was a problem hiding this comment.
We could also "just" call it zip and rely on the overload resolution ;)
marzipankaiser
changed the title
These and zipLongest on lists and streamsOneOrBoth and zipLongest on lists and streams
jiribenes
left a comment
jiribenes
left a comment
There was a problem hiding this comment.
I'd still prefer a different name than zipLongest, but I'm fine with the contents, so feel free to merge this if you want to, @marzipankaiser
No description provided.