Mutable arrays in the LLVM backend #477
Conversation
phischu
force-pushed
the
llvm/mutable_arrays
branch
from
f90caa3 to
5e451e0
Compare
phischu
changed the title
|
Really great, thanks that you implemented both arrays and refs. Btw, in my drafts of promises in #469 I tried to stick to a similar strategy of storing the eraser after the RC and treat Promise as Pos this way. One issue that I have is: do you really want to directly test the "unsafe" variants? |
phischu
force-pushed
the
llvm/mutable_arrays
branch
from
dc91c3c to
901c480
Compare
| * | ||
| * +--[ Header ]--+------+------------+ | ||
| * | Rc | Eraser | Size | Fields ... | | ||
| * +--------------+------+------------+ |
There was a problem hiding this comment.
I guess we do not save the size in the tag because we need it in the eraser?
| /** | ||
| * Creates a new Array of size `size` filled with the value `init` | ||
| */ | ||
| extern global def fresh[T](size: Int, init: T): Array[T] = |
There was a problem hiding this comment.
Note that fill is also already used in the stdlib for the same operation on lists — it might be worth it to think about synchronizing the two names.
There was a problem hiding this comment.
Hmm.. here we used fresh since it is the same name as for Ref.
|
We would like to rename: unsafeFresh -> allocate document in allocate that the default constructor should be preferred and that it is unsafe... |
No description provided.