Translation update, slash commands errors handler added #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! I left a comment before we can merge :) Would you mind making that change? |
|
I don't got it |
|
I pushed a commit in the PR branch. It should work as intended now. Thanks for spotting the issue on command errors not being captured. |
eibex
approved these changes
Feb 18, 2024
cogs/errors.py
Outdated
| @@ -41,6 +41,14 @@ async def on_command_error(self, inter, error): | |||
| traceback.print_tb(error.__traceback__) | |||
| print(error) | |||
|
|
|||
| @commands.Cog.listener() | |||
| async def on_slash_command_error(self, inter, error): | |||
There was a problem hiding this comment.
It would be better to delete this block and transform the function above to on_slash_command_error instead of on_command_error since we only have slash commands.
|
You're welcome. Glad to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changes
ru-ru.jsoncogs/errors.py