.gitlab-ci.yml: introduce global SNAKEMAKE_FLAGS, don't re-run based on mtime #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all workflows to ignore mtime. In principle, we shouldn't need re-run anything ever on CI – all that is produced is produced anew except what's cached.
The issue reported in eic/epic#796 (comment)
happens specifically in bench:backwards_ecal, because it's the only workflow with caching. My hypothesis is that several parallel simm:backwards_ecals may overwrite edm4hep files in the cache twice with different mtimes, then in bench step the reconstructed edm4eic may appear to be out of date with respect to the latest mtime in cache. That causes reconstruction to be re-ran in a single bench job and cause a time out. If we can just ignore mtime, that should stop being a problem.
This also applies --cache globally, which should be harmless.