Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to track in a BeamPipeChain #768

Merged
merged 23 commits into from
Oct 12, 2024
Merged

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Aug 15, 2024

Briefly, what does this PR introduce?

An option had been added to include sensitive elements at the start and/or end of beam pipe vacuum. This allows easy tracking of the shape and position of beam electrons/protons to compare with accelerator group and stand alone simulations. The segment in which scattered electrons of different kinematics can also be studied/verified.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@simonge
Copy link
Contributor Author

simonge commented Aug 20, 2024

This will be extended to include a specific configuration for testing along with a benchmark script and sample beam particle events.

@simonge
Copy link
Contributor Author

simonge commented Sep 6, 2024

Is there some way to turn on/off the sensitivity of a detector via a flag/constant in a config file? Ideally this readout would be off unless the (e.g.) ip6_extended config was used.

At the moment I can only work out how to do this by completely copying the magnets.xml file and adding a readout and sensitive flag there.

@veprbl
Copy link
Member

veprbl commented Sep 6, 2024

I think, using the files is the way to go. To reduce duplication, you may need to abuse <include>s.

@simonge
Copy link
Contributor Author

simonge commented Sep 13, 2024

The approach I've currently implemented seems to work. Where additional detectors elements are created in entirely separate code and injected into the relevant beampipe segment.

@simonge
Copy link
Contributor Author

simonge commented Oct 9, 2024

Please can someone review this, it is aimed at benchmarks which will compare the electron beam shape progression between the simulation and those expected by the accelerator lattice.

One thing I'd like to discuss is how best to terminate the electron beam beyond where it's needed, which is relevant beyond the core of this PR. Speeding up single beam electron simulations ~200x. At the moment I have introduced a filter which kills all particles which enter a volume and just added that to a vacuum element in the pipe, might it be better to instead introduce a new geometry element "BeamStop" which is placed in the beamline instead of changing what's there?

Chao1009
Chao1009 previously approved these changes Oct 10, 2024
Copy link
Contributor

@Chao1009 Chao1009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@veprbl veprbl added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2024
@veprbl veprbl added this pull request to the merge queue Oct 11, 2024
@simonge simonge removed this pull request from the merge queue due to a manual request Oct 11, 2024
@simonge
Copy link
Contributor Author

simonge commented Oct 11, 2024

Apologies I decided to move to the beamstop implementation and needed to give the assembly a token ID for the benchmark to run.

@simonge simonge added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@simonge simonge added this pull request to the merge queue Oct 12, 2024
Merged via the queue into main with commit b3588d6 Oct 12, 2024
115 checks passed
@simonge simonge deleted the Add_Beampipe_tracking branch October 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants