Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert granularity #771

Merged
merged 33 commits into from
Aug 25, 2024
Merged

Insert granularity #771

merged 33 commits into from
Aug 25, 2024

Commits on Aug 20, 2024

  1. Update forward_insert.xml 

    multisegmentation for the insert
    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3e8404d View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d838546 View commit details
    Browse the repository at this point in the history

  3. Update forward_insert.xml 

    syntax error corrected
    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    cbd796c View commit details
    Browse the repository at this point in the history

  4. Update InsertCalorimeter_geo.cpp 

    add gap between left and right sides of the detector.  This also allows separate segmentations on the left and right sides of the detector
    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8d9c2ef View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6057919 View commit details
    Browse the repository at this point in the history

  6. Update forward_insert.xml 

    updated documentation, also use 60 layers instead of 65
    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5042998 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1fcbc36 View commit details
    Browse the repository at this point in the history

  8. Update InsertCalorimeter_geo.cpp

    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8211aed View commit details
    Browse the repository at this point in the history

  9. Update InsertCalorimeter_geo.cpp

    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c83af09 View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e480086 View commit details
    Browse the repository at this point in the history

  11. Update InsertCalorimeter_geo.cpp

    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    24708f4 View commit details
    Browse the repository at this point in the history

  12. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    401440a View commit details
    Browse the repository at this point in the history

  13. Update forward_insert.xml 

    include "side" as an id field
    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    effcf93 View commit details
    Browse the repository at this point in the history

  14. Update InsertCalorimeter_geo.cpp

    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2f16451 View commit details
    Browse the repository at this point in the history

  15. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    44e1912 View commit details
    Browse the repository at this point in the history

  16. Update forward_insert_homogeneous.xml 

    Force Ecal insert to use "side" as a readout field, so that things don't crash.
    @sebouh137
    sebouh137 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    386029f View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Update InsertCalorimeter_geo.cpp 

    fixed issue for subtraction volume.
    @sebouh137
    sebouh137 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    78a87a4 View commit details
    Browse the repository at this point in the history

  2. Update forward_insert.xml 

    refactoring the segmentation
    @sebouh137
    sebouh137 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3ba7d8a View commit details
    Browse the repository at this point in the history

  3. updated the segmentations to update what I have in my layouts. note: … 

    …row and column numbers may need to be adjusted by integer offsets, and the margin between the LR edges of the detector and the corners of the hexagons have not been included yet
    @sebouh137
    sebouh137 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3b2e54e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. include a gap between the edge of the PCB and the corners of the hexa… 

    …gonal tiles
    @sebouh137
    sebouh137 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0b1b090 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into insert_multiseg

    @sebouh137
    sebouh137 authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b3a6a6f View commit details
    Browse the repository at this point in the history

  3. removed front plate of insert

    @sebouh137
    sebouh137 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    821b11c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'insert_multiseg' of https://github.com/eic/epic into in… 

    …sert_multiseg
    @sebouh137
    sebouh137 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    20cf60a View commit details
    Browse the repository at this point in the history

  5. changed number of hg layers from 20 to 16

    @sebouh137
    sebouh137 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    96ba413 View commit details
    Browse the repository at this point in the history

  6. changed number of hg layers from 20 to 16

    @sebouh137
    sebouh137 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ae3102b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Update compact/hcal/forward_insert.xml 

    Co-authored-by: Ryan Milton <87345122+rymilton@users.noreply.github.com>
    @sebouh137 @rymilton
    sebouh137 and rymilton authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0684e3e View commit details
    Browse the repository at this point in the history

  2. Update compact/hcal/forward_insert.xml 

    Thanks for catching this

Co-authored-by: Ryan Milton <87345122+rymilton@users.noreply.github.com>
    @sebouh137 @rymilton
    sebouh137 and rymilton authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b9275b7 View commit details
    Browse the repository at this point in the history

  3. Update compact/hcal/forward_insert.xml 

    Co-authored-by: Ryan Milton <87345122+rymilton@users.noreply.github.com>
    @sebouh137 @rymilton
    sebouh137 and rymilton authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0ae4099 View commit details
    Browse the repository at this point in the history

  4. Update compact/hcal/forward_insert.xml 

    Co-authored-by: Ryan Milton <87345122+rymilton@users.noreply.github.com>
    @sebouh137 @rymilton
    sebouh137 and rymilton authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0a28d1d View commit details
    Browse the repository at this point in the history

  5. Update forward_insert.xml 

    included left_right_gap in the forward_insert.xml
    @sebouh137
    sebouh137 authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    df4a0e5 View commit details
    Browse the repository at this point in the history

  6. Update forward_insert_homogeneous.xml 

    use same left right gap for the forward ecal insert as for the hcal insert (for now).
    @sebouh137
    sebouh137 authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    34483a4 View commit details
    Browse the repository at this point in the history

  7. Update InsertCalorimeter_geo.cpp 

    updated the gap to match the value in the xml
    @sebouh137
    sebouh137 authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0e9d93c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into insert_multiseg

    @sebouh137
    sebouh137 authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6464ff2 View commit details
    Browse the repository at this point in the history