No zdc lyso #785
No zdc lyso #785
Conversation
…e purpose of this is to reduce the number of channels to a more manageable number.
github-actions
bot
added
topic: forward
|
@bschmookler , we should be using the new configuration I created for most of the ZDC detector benchmarks, instead of the zdc_sipm_on_tile_only configuration (which, as the name suggests, contains only the ZDC sipm-on-tile, and nothing else, no beampipe, etc.). Please approve this request so that I can use it for the detector benchmarks and therefore include things like the beampipe. |
|
Do you know why many of the checks failed? |
I'm not sure. What I essentially did was remove far_forward default (which contains everything in the far forward), and added each of the far forward components individually. I'll have to see if there's any nuances that I am missing in there. |
Ok, found it. accidentally wrote "roman_pots_pots" instead of roman_pots somewhere in the new config (I had added each of the far forward parts manually, instead of using the default, so this was a typo in here). |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@veprbl why is this not merging? |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Looks like runners on eicweb were clogged with other work. I've manually cancelled few things, but it would not unclog in time. |
Briefly, what does this PR introduce?
Creates a configuration with everything from craterlake in it, except for the ZDC LYSO
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
no