Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update material map script for acts v35.2 #826

Merged
merged 11 commits into from
Feb 9, 2025
Merged

update material map script for acts v35.2 #826

merged 11 commits into from
Feb 9, 2025

Conversation

ShujieL
Copy link
Contributor

@ShujieL ShujieL commented Feb 6, 2025

Briefly, what does this PR introduce?

Update the material map script to acts 35.2 to allow saving map in cbor format. Tested with jug_xl nightly, 02042025

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [ x] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [x ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

N/A

Does this PR change default behavior?

N/A

ShujieL and others added 3 commits February 6, 2025 15:09
…instead of json. Also added plots for geometry visualizaion
…ny materials outside of the tracking volume, e.g. in the barrel (BIC, solenoid) and backward region to reduce the processing size.
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Feb 6, 2025
@ShujieL ShujieL added topic: tracking and removed topic: infrastructure Regarding build system, CI, CD labels Feb 7, 2025
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Feb 7, 2025
@ShujieL ShujieL requested review from wdconinc and veprbl February 7, 2025 18:27
ShujieL and others added 2 commits February 7, 2025 15:17
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl enabled auto-merge (squash) February 7, 2025 23:25
@veprbl veprbl merged commit 891ceb5 into main Feb 9, 2025
82 checks passed
@veprbl veprbl deleted the material_map branch February 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD topic: tracking
Projects
Development

Successfully merging this pull request may close these issues.

4 participants