-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoinstall through https://github.com/phpstan/extension-installer #17
Conversation
What a modernization! |
Try using |
|
thx @spawnia for contributing. agreed with @szepeviktor on the 2 points. I would add don't forget to update Changelog and if you can squash your commit that would be great. thx again for this modernization 😄 |
I would argue it is a dev dependency, as dev's are expected to run it and it is useful to validate in CI. There is no hard requirement that forces it to be installed globally. |
You can squash on merge, the title of the PR should make a good commit message. |
Thanks @spawnia for the contribution! About commits, of course we can squash them on merge, but it's easier for the merger if the submitted PR is "clean", because no need talking about that, and the author gets the opportunity to update the commit message to have a proper one. |
No description provided.