-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iamserviceaccount create
duplicate entry check not being behind the created flag
#5080
Fix iamserviceaccount create
duplicate entry check not being behind the created flag
#5080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: is this needs a skip-release-notes
label? If not then can we add a good title description that goes in release notes :)
@Himangini Yeah, I was thinking about that too! I think you're right. I should create a bug for this. :) |
create
not checking for override flag being set to true
create
not checking for override flag being set to truecreate
duplicate entry check not being behind the created flag
Added an issue and title. :) |
I will run a crud test for this tomorrow. |
I don't think it needs to be mentioned in the release notes since its fixing a bug that never existed (never released) 😁 |
Description
Fix the crud duplication test failure by only checking duplication if the flag is on.
Introduced in this pr: #4963
Closes #5081
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯