Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iamserviceaccount create duplicate entry check not being behind the created flag #5080

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 6, 2022

Description

Fix the crud duplication test failure by only checking duplication if the flag is on.

Introduced in this pr: #4963

Closes #5081

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is this needs a skip-release-notes label? If not then can we add a good title description that goes in release notes :)

@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 6, 2022

@Himangini Yeah, I was thinking about that too! I think you're right. I should create a bug for this. :)

@Skarlso Skarlso changed the title Fix duplicate entry check Fix duplicate entry check for iamserviceaccount create not checking for override flag being set to true Apr 6, 2022
@Skarlso Skarlso changed the title Fix duplicate entry check for iamserviceaccount create not checking for override flag being set to true Fix iamserviceaccount create duplicate entry check not being behind the created flag Apr 6, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 6, 2022

Added an issue and title. :)

@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 6, 2022

I will run a crud test for this tomorrow.

@aclevername
Copy link
Contributor

aclevername commented Apr 6, 2022

@Himangini Yeah, I was thinking about that too! I think you're right. I should create a bug for this. :)

I don't think it needs to be mentioned in the release notes since its fixing a bug that never existed (never released) 😁

@Skarlso Skarlso enabled auto-merge (squash) April 7, 2022 06:00
@Skarlso Skarlso merged commit cfde8c9 into eksctl-io:main Apr 7, 2022
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 11, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]
3 participants