Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting clusters with a non-active status #7728

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Apr 26, 2024

Description

eksctl was failing to delete clusters that are in a non-active state, e.g., CREATING.
This was caught in the before_active integration test.

This changelist checks if the cluster is operable before creating tasks for pod identity deletion.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added kind/bug skip-release-notes Causes PR not to show in release notes labels Apr 26, 2024
@cPu1 cPu1 changed the title Fix deleting clusters with a non-active state Fix deleting clusters with a non-active status Apr 26, 2024
@cPu1 cPu1 force-pushed the fix-delete-cluster branch from 23757a0 to 119b4c4 Compare April 26, 2024 10:11
@cPu1 cPu1 merged commit 98e1228 into eksctl-io:main Apr 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants