Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-ssm ami resolution for ubuntu #7851

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Jun 26, 2024

Description

Add auto-ssm ami resolution for ubuntu

Issue #3224

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Manual tests

EKSCTL=eksctl
CLUSTER_NAME=my-cluster
COMMON_ARGS=( --verbose 5 )

${EKSCTL} "${COMMON_ARGS[@]}" create cluster -f - << EOF
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: ${CLUSTER_NAME}
  region: eu-south-2
  version: '1.30'

nodeGroups:
  - name: ng-ubuntu
    instanceType: t3.micro
    desiredCapacity: 1
    amiFamily: Ubuntu2204
    ami: auto-ssm
    ssh:
        allow: true
    overrideBootstrapCommand: |
      #!/bin/bash
      /etc/eks/bootstrap.sh ${CLUSTER_NAME} >> /var/log/bootstrap.log
EOF
} 2>&1 >/tmp/eksctl.log

$ grep -i ssm /tmp/eksctl.log
265:2024-07-05 12:55:26 [▶]  resolving AMI using SSM Parameter resolver for region eu-south-2, instanceType t3.micro and imageFamily Ubuntu2204

@aciba90
Copy link
Contributor Author

aciba90 commented Jun 26, 2024

Hello team. I created this PR as draft because unit tests are broken due to #7845. Will work on them after unblocked, thanks.

@aciba90 aciba90 force-pushed the ubuntu-ssm-ami-resolution-3224 branch from e540ab4 to 13a7f46 Compare July 5, 2024 11:15
@aciba90 aciba90 marked this pull request as ready for review July 5, 2024 11:42
@cPu1 cPu1 force-pushed the ubuntu-ssm-ami-resolution-3224 branch from 13a7f46 to d329894 Compare July 8, 2024 09:09
Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, this is very thorough.

@cPu1 cPu1 merged commit 9150dcb into eksctl-io:main Jul 8, 2024
10 of 11 checks passed
@aciba90 aciba90 deleted the ubuntu-ssm-ami-resolution-3224 branch July 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants