Documentation: correct version drift limits in cluster-upgrade.md #7994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello larvacea 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website
TiberiuGC
reviewed
Oct 9, 2024
| Kubernetes supports version drift of up-to two minor versions during upgrade | ||
| process. So nodes can be up to two minor versions ahead or behind the control plane | ||
| Kubernetes supports version drift of up-to two minor versions during the upgrade | ||
| process. Nodes can be up to two minor versions behind the control plane |
There was a problem hiding this comment.
Suggested change
| process. Nodes can be up to two minor versions behind the control plane | |
| process. Nodes can be up to two minor versions behind, but never ahead of, the control plane |
TiberiuGC
reviewed
Oct 9, 2024
Comment on lines
18
to
19
| nodes can be upgraded more than one minor version at a time, provided the nodes stay | ||
| within two minor versions of the control plane. |
There was a problem hiding this comment.
Suggested change
| nodes can be upgraded more than one minor version at a time, provided the nodes stay | |
| within two minor versions of the control plane. | |
| nodes can be upgraded more than one minor version at a time, provided their version does not become greater than the control plane version. |
|
Thank you @larvacea ! Left a couple suggestions to further stress that node version cannot exceed control plane version. |
|
I've incorporated your suggestions; thanks! |
Correct the description of version drift during upgrade to match the current kubernetes documentation. Node version should not be newer than the cluster version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the description of version drift during upgrade to match the current kubernetes documentation. Node version should not be newer than the cluster version.
Description
Kubernetes requires that the version of each
kubeletin a cluster be no newer than the oldestkube-apiserverin the cluster. A note in cluster-upgrade.md said that a node could be up to two minor versions ahead or behind thecluster version during upgrade.
I encountered this while adding a nodegroup running a 1.31 AMI to a cluster running 1.30: the instance failed during network initialization and could not join the cluster. Upgrading the cluster to 1.31 fixed the problem: the failing nodes were able to join the 1.31 cluster.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯