Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot receive result from canLoad within some iframes #23

Closed
el1t opened this issue Jan 28, 2017 · 1 comment
Closed

Cannot receive result from canLoad within some iframes #23

el1t opened this issue Jan 28, 2017 · 1 comment

Comments

@el1t
Copy link
Owner

el1t commented Jan 28, 2017

Describe the issue

When an iframe is created through document.write and src is set to a JS object, safari.self.tab.canLoad() will return undefined to while within the iframe. This causes some requests to slip through.

One or more specific URLs where the issue occurs

https://iframe-example.surge.sh

adgear example: http://noovo.ca
note this does not occur in https://iframe-example2.surge.sh

Steps for anyone to reproduce the issue

  1. Visit site that creates iframe in a particular manner

Your settings

  • Safari version: 10.0.3
  • uBlock Origin version: 1.10.5.9
  • MacOS version: 10.11.6
Your filter lists

Default (irrelevant)

@el1t
Copy link
Owner Author

el1t commented Jan 28, 2017

Sometimes self.top.safari is used when self.safari is not defined (for example, https://iframe-example.surge.sh). For whatever reason, Safari expects self.safari to be defined always.

@el1t el1t closed this as completed in 3d92053 Jan 28, 2017
el1t added a commit that referenced this issue Feb 3, 2017
slightly cleaner and safer approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant