Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to measure the "relatively stable" milestone? #34

Open
jmfederico opened this issue Mar 11, 2017 · 25 comments
Open

How to measure the "relatively stable" milestone? #34

jmfederico opened this issue Mar 11, 2017 · 25 comments
Labels
question

Comments

@jmfederico
Copy link

Hi,

Is there a path to know when this plugin will be considered "relatively stable"?

If not, should there be one? I've seen projects stay forever in "pre-release" phase, and would like this one not to be one.
@el1t el1t added the question label Mar 17, 2017
@el1t
Copy link
Owner

el1t commented Mar 17, 2017

Good point, and I think releasing it to the extension gallery would make both installation and updates much easier. Of course it'd be nice to have as much feature parity with the Chrome version as possible. My primary concern for release, though, are unblocked connections. (For example, when Safari allows a connection that Chrome would have blocked.)

I'm open to suggestions—is there any particular issue to be addressed prior to release? I don't anticipate breaking changes in the vAPI, in any case.

@jmfederico
Copy link
Author

Can you link here the issues that would block the release? Like "unblocked connections" that you mention?

@x0wl
Copy link

x0wl commented Apr 7, 2017 •
edited
Loading

But it's already in the extension gallery, am I not getting something?

@chrisgonyea
Copy link

Yeah, I see it on the extension gallery already. https://safari-extensions.apple.com/?q=ublock

@el1t
Copy link
Owner

el1t commented Apr 9, 2017

That's not mine! I'm not sure who uploaded it. I would like to look into ping and webworker requests before releasing. Been kind of busy lately, but I'll try to get it ready asap.

@jmfederico
Copy link
Author

Is there a way to know we published it to the extension gallery?

@el1t
Copy link
Owner

el1t commented Apr 9, 2017

@jmfederico I'll link it here and on the readme

@jmfederico
Copy link
Author

Ah, I just noticed a mistake on my post: The question was meant to be:

Is there a way to know who published it to the extension gallery?

Don't know where the we came from.

@el1t
Copy link
Owner

el1t commented Apr 11, 2017

@jmfederico I don't know if that's possible; the extension may have been resigned by the Extension Gallery. It's definitely an issue though, as I doubt I'm allowed to upload a duplicate extension. Hopefully whoever uploaded it will pull it...

On the other hand, you can verify the SHA-256 fingerprint of the cert that I'm using to sign the releases I upload to Github is as follows:

A1 E6 03 7F 11 9E CA B1 52 5D 5A B0 D9 67 05 56 95 54 0A FE 4B E5 A6 22 7B 1E D3 00 BB 34 9A 33

@hartator
Copy link

@el1t I am the one who published the extension.

Sorry for the trouble, I didn't understood that the extension wasn't stable enough and was surprised it wasn't already on the extension gallery. I though it was linked to you guys not having a marketing website and a proper SVG logo knowing Apple can be tricky to accept apps in their App store for these reasons. So, I made a marketing site in a few hours, re-draw a HD version of the uBlock Origin logo and submitted it to Apple. (https://hartator.github.io/uBlock-Safari/).

I had to re-sign the extension for the submission, but for what's worth I didn't modify any of the code, so it should self-update against this GitHub like the other extensions.

I don't seem to have any direct control it though, it seems they have a manual process for Safari extensions. I know about it through this thread as they also didn't sent me any email. I only know it's my submission because the HD logo they are using matches mine.

Anyway, thanks for the awesome work you guys have been doing, I am a big fan.

What course of action do you want me to take?

I can ask them to take it down by sending them an email - I am not finding a control panel like regular iOS and MacOS apps - or you can just submit here when you update: https://developer.apple.com/safari/extensions/submission/ They seem to follow a complete manual process, so a small explanation should be enough.

@el1t
Copy link
Owner

el1t commented Apr 12, 2017

@hartator That's alright, thanks for letting me know. I would just ask that you send an email/support request to pull it, if possible. I'll try to upload it officially in a week or so. I appreciate the support!

@hartator
Copy link

hartator commented Apr 12, 2017 via email

@hartator
Copy link

hartator commented Apr 13, 2017 •
edited
Loading

@el1t Ok, I've asked to remove the extension using same form as before. There is no ways to contact them directly unfortunately. Let me know if I can do anything more to help.

@DevSysEngineer
Copy link

Any update about this?

@ruchernchong
Copy link

@el1t Roughly how often will the updates be pushed to the extension gallery when there is a new release here?

@ruchernchong ruchernchong mentioned this issue Jun 13, 2017
Open
@el1t
Copy link
Owner

el1t commented Jun 21, 2017

I will try to submit an update to the extension gallery whenever I submit a release here. I have actually submitted 1.12.5b to the gallery, but it's been some time and Apple still hasn't updated. I'll post here if/when they do.

@vassudanagunta
Copy link

vassudanagunta commented Jul 10, 2017 •
edited
Loading

I just installed the uBlock Origin in the Extensions Gallery (https://safari-extensions.apple.com/?q=ublock). Note that the Gallery shows the author as "Chris Aljoudi/Raymond Hill", but links to https://github.com/el1t/uBlock-Safari. The installed version is 1.11.3.1.

Should I not use this?

@ruchernchong
Copy link

ruchernchong commented Jul 10, 2017 •
edited
Loading

@vassudanagunta That is the version I am using. Should be fine.

@el1t
Copy link
Owner

el1t commented Jul 10, 2017 via email

@amarendra
Copy link

Hey @el1t, is this #59 intended? The issue says the update URL is linked to chrismatic.io.

@ServerWrestler
Copy link

If @gorhill or @el1t isn't involved with this on the apple site https://safari-extensions.apple.com/details/?id=com.el1t.uBlock-8782JU4WM4 then I suggested it be removed as mentioned above. It's been a while, any luck?

@ServerWrestler ServerWrestler mentioned this issue Aug 28, 2017
Closed
@vassudanagunta
Copy link

It appears that the unauthorized publish of uBlock Origin to the Extensions Gallery by @hartator has been pulled. It no longer comes up on search (https://safari-extensions.apple.com/?q=ublock).

@el1t maybe you can publish the latest release now (and close this issue)?

@bryandmlee
Copy link

@vassudanagunta The direct link for the Extensions Gallery version is still "live": https://safari-extensions.apple.com/details/?id=com.el1t.uBlock-8782JU4WM4, and its install link still works though. I can second that the search query doesn't show any results now, however.

@ghost
Copy link

ghost commented Sep 11, 2017

... also the "security" section still lists UBO. It seems to be very persistent. It was a very bad call from hartator to upload the extension without consulting el1t first it seems. I hope this can be resolved somehow as I generally would like autoupdates for the Safari fork/port of UBO.

@vassudanagunta vassudanagunta mentioned this issue Oct 10, 2017
Closed
@vassudanagunta
Copy link

vassudanagunta commented Oct 10, 2017 •
edited
Loading

Agreed. A very bad call. I created new issue #69 because it deserves priority attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests