Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default service version to module version #456

Open
axw opened this issue Feb 26, 2019 · 1 comment
Open

Set default service version to module version #456

axw opened this issue Feb 26, 2019 · 1 comment
Labels
blocked

Comments

@axw
Copy link
Member

axw commented Feb 26, 2019

Go 1.12 introduces https://golang.org/pkg/runtime/debug/#BuildInfo, which will report module information if the program was built using modules.

If no service version is specified, we should default to the main module version.
@axw
Copy link
Member Author

axw commented Feb 26, 2019

This doesn't really work, since there's no way to specify the main module's version, only the versions of dependencies. Relevant: golang/go#29814.

@axw axw mentioned this issue Feb 17, 2021
Closed
@simitt simitt added the v7.16.0 label Aug 23, 2021
@simitt simitt added this to the 7.16 milestone Aug 23, 2021
@zube zube bot removed this from the 7.16 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graphaelli @axw @simitt @alvarolobato