Skip to content

Conversation

@Qard
Copy link
Contributor

@Qard Qard commented Jul 29, 2019

Closes #1098

@Qard Qard requested a review from watson July 29, 2019 09:27
@Qard Qard self-assigned this Jul 29, 2019
@Qard
Copy link
Contributor Author

Qard commented Jul 29, 2019

Not sure why @hapi/hoek is causing wait-on to fail. I feel like there must be missing content in that log. 🤔

@Qard
Copy link
Contributor Author

Qard commented Jul 30, 2019

Ah...apparently wait-on changed the dependency on joi to the newer @hapi/joi in 3.3.0, which drops Node.js 6.x compatibility in a minor...

@watson
Copy link
Contributor

watson commented Jul 31, 2019

I think this is a duplicate of #1098?

@Qard
Copy link
Contributor Author

Qard commented Jul 31, 2019

It's a squash + rebase of #1098 with a commit message rewrite so it'd actually pass the commit lint and trigger the tav tests on Travis.

@watson watson merged commit 76a34a6 into elastic:master Aug 7, 2019
@Qard Qard deleted the renamed-hapi branch August 7, 2019 12:33
v1v pushed a commit to v1v/apm-agent-nodejs that referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants