Skip to content

Conversation

@SimonSimCity
Copy link
Contributor

@SimonSimCity SimonSimCity commented Apr 23, 2020

PR for #1701 - adding a hint to the performance tips showing how to ignore spans having a short duration.

Needs to be checked by a native English speaker ...

Checklist

@watson watson added the docs label Apr 23, 2020
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR 💯I just left a few review comments

@watson watson requested a review from bmorelli25 April 23, 2020 18:45
@bmorelli25
Copy link
Member

Thanks so much @SimonSimCity! Once @watson's recommendations have been implemented I'll kick off the docs ci to ensure everything builds nicely :)

@bmorelli25 bmorelli25 linked an issue Apr 24, 2020 that may be closed by this pull request
@SimonSimCity
Copy link
Contributor Author

Thanks, I've just updated the pull-request.

Please also take the time to comment to my other two pull-requests, where it is about code I'd like to have in.

Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny little change with a missing ---- to open the code block so that it renders correctly. Otherwise all good 👍

@SimonSimCity SimonSimCity force-pushed the doc-max-span-duration branch from 902b9df to a194b8e Compare April 27, 2020 07:22
@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

Thank you! I'm running a final doc build. If that passes, I think we're good to go!

bmorelli25
bmorelli25 previously approved these changes Apr 27, 2020
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs preview LGTM. Thank you again!

@bmorelli25
Copy link
Member

@SimonSimCity it looks like the approved-contributor check is failing. Can you please sign the contributor agreement with the same email address you used for these commits?

@SimonSimCity
Copy link
Contributor Author

@bmorelli25 I've done this already last week (see: #1724 (comment))

@ghost
Copy link

ghost commented May 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@bmorelli25 bmorelli25 self-assigned this May 7, 2020
@bmorelli25
Copy link
Member

bmorelli25 commented May 7, 2020

Assigning myself so this doesn't get lost. @watson, can I merge this even if the Travis CI build fails? I'll merge master to run tests again.

@watson watson merged commit 04430a1 into elastic:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to ignore spans that are shorter than x milliseconds

3 participants