-
Notifications
You must be signed in to change notification settings - Fork 238
docs: hint how to ignore spans if very short #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
watson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR 💯I just left a few review comments
|
Thanks so much @SimonSimCity! Once @watson's recommendations have been implemented I'll kick off the docs ci to ensure everything builds nicely :) |
|
Thanks, I've just updated the pull-request. Please also take the time to comment to my other two pull-requests, where it is about code I'd like to have in. |
watson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny little change with a missing ---- to open the code block so that it renders correctly. Otherwise all good 👍
902b9df to
a194b8e
Compare
|
@elasticmachine, run elasticsearch-ci/docs |
|
Thank you! I'm running a final doc build. If that passes, I think we're good to go! |
bmorelli25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs preview LGTM. Thank you again!
|
@SimonSimCity it looks like the approved-contributor check is failing. Can you please sign the contributor agreement with the same email address you used for these commits? |
|
@bmorelli25 I've done this already last week (see: #1724 (comment)) |
💚 Build SucceededExpand to view the summary
Build stats
|
|
Assigning myself so this doesn't get lost. @watson, can I merge this even if the Travis CI build fails? I'll merge master to run tests again. |
PR for #1701 - adding a hint to the performance tips showing how to ignore spans having a short duration.
Needs to be checked by a native English speaker ...
Checklist