Skip to content

fix: SpanOptions type should include 'startTime' #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2021
Merged

fix: SpanOptions type should include 'startTime' #2339

merged 3 commits into from
Sep 20, 2021

Conversation

@trentm
Copy link
Member

@trentm trentm commented Sep 17, 2021

Noticed by @sqren

Checklist

@trentm trentm requested a review from astorm September 17, 2021 21:42
@trentm trentm self-assigned this Sep 17, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 17, 2021
@ghost
Copy link

ghost commented Sep 17, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-20T16:27:56.168+0000

  • Duration: 19 min 17 sec

  • Commit: c36810d

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

Trends 🧪

Image of Build Times

Image of Tests

sorenlouv
sorenlouv approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trentm trentm merged commit 52d5ffc into master Sep 20, 2021
@trentm trentm deleted the trentm/types-spanoptions-starttime branch September 20, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

+1 more reviewer

@astorm astorm astorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trentm trentm

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trentm @astorm @sorenlouv