test: fix '-f' force option usage with test driver script #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally running '.ci/scripts/test.sh -b rc 18' -- to run tests against a node v18 RC build -- would skip out because the latest RC build is for a version that has an actual release. The '-f' flag exists to allow still testing with that RC, which can be useful for dev work. At some point this was busted, `NODE_FULL_VERSION` wouldn't be set and a build step in ".ci/docker/node-edge-container/Dockerfile" would fail (the `nvm install $NODE_FULL_VERSION`).
github-actions
bot
added
the
agent-nodejs
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
Normally running '.ci/scripts/test.sh -b rc 18' -- to run tests against a node v18 RC build -- would skip out because the latest RC build is for a version that has an actual release. The '-f' flag exists to allow still testing with that RC, which can be useful for dev work. At some point this was busted, `NODE_FULL_VERSION` wouldn't be set and a build step in ".ci/docker/node-edge-container/Dockerfile" would fail (the `nvm install $NODE_FULL_VERSION`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally running '.ci/scripts/test.sh -b rc 18' -- to run tests against
a node v18 RC build -- would skip out because the latest RC build is for
a version that has an actual release. The '-f' flag exists to allow
still testing with that RC, which can be useful for dev work.
At some point this was busted,
NODE_FULL_VERSIONwouldn't be set anda build step in ".ci/docker/node-edge-container/Dockerfile" would fail
(the
nvm install $NODE_FULL_VERSION).