Skip to content

chore: sync package-lock so 'npm ci' can work #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

chore: sync package-lock so 'npm ci' can work #3318

merged 1 commit into from
May 5, 2023

Conversation

@trentm
Copy link
Member

@trentm trentm commented May 4, 2023

The package.json change in #3203 did not sync the package-lock file. The result is that npm ci fails:

% npm ci
npm ERR! code EUSAGE
npm ERR!
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR!
npm ERR! Missing: @types/node-fetch@2.6.3 from lock file
npm ERR! Missing: form-data@3.0.1 from lock file

We only currently use npm ci for releases, not for other CI tests, so this isn't critical yet.
This is the first time I've made this error. If it happens at all frequently, we could add a CI check for this.

@trentm trentm requested a review from david-luna May 4, 2023 18:43
@trentm trentm self-assigned this May 4, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 4, 2023
@david-luna david-luna merged commit fcdd868 into main May 5, 2023
@david-luna david-luna deleted the trentm/sync-package-lock branch May 5, 2023 13:41
v1v added a commit to v1v/apm-agent-nodejs that referenced this pull request May 8, 2023
@v1v
Merge branch 'main' of github.com:elastic/apm-agent-nodejs into featu…
a9130f7 
…re/support-specific-modules

* 'main' of github.com:elastic/apm-agent-nodejs: (54 commits)
  chore: fix dev-utils/ci-tav-slow-jobs.sh (elastic#3319)
  test: reduce TAV test matrix for slowest jobs (elastic#3321)
  chore: sync package-lock so 'npm ci' can work (elastic#3318)
  docs: document `useElasticTraceparentHeader` config var (elastic#3316)
  chore, test: test driver improvements (elastic#3293)
  test: drop node 14 from RC tests now that it is EOL (elastic#3315)
  test: fix running fastify.test.js with node v8 (elastic#3317)
  feat: add @apollo/server@4 support (elastic#3203)
  chore: update nvm (elastic#3309)
  tests: stop testing 'express-graphql' instrumentation (elastic#3304)
  chore: fix bitrot.js dev util for recent changes (elastic#3308)
  test: restore testing of Azure Functions on node >=18.x (elastic#3307)
  fix: support Lambda instrumentation for `contextManager: 'patch'`; refactor Lambda tests (elastic#3305)
  test: fix fastify TAV test failures (elastic#3314)
  test: fix @aws-sdk/client-s3 TAV test failures (elastic#3312)
  feat: add instrumentation for aws-sdk S3 client (elastic#3287)
  feat(fastify): add captureBody support (elastic#2681)
  feat: mysql2@3 support (elastic#3301)
  chore(deps): bump @opentelemetry/exporter-prometheus from 0.37.0 to 0.38.0 in /test/opentelemetry-metrics/fixtures (elastic#3295)
  chore(deps-dev): bump fastify from 4.16.3 to 4.17.0 (elastic#3296)
  ...
trentm added a commit that referenced this pull request May 16, 2023
@trentm
chore: sync package-lock so 'npm ci' can work (#3318)
d56f784
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@trentm @PeterEinberger
chore: sync package-lock so 'npm ci' can work (elastic#3318)
745a9d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-luna david-luna david-luna approved these changes

Assignees

@trentm trentm

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trentm @david-luna