Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename apm-mutating-webhook to apm-k8s-attacher #12222

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

amannocci
Copy link
Contributor

What is the change being made?

  • Rename apm-mutating-webhook to apm-k8s-attacher

Why is the change being made?

  • The repository apm-mutating-webhook has been renamed to apm-k8s-attacher.

@amannocci amannocci requested a review from a team as a code owner December 13, 2023 17:10
Copy link
Contributor

mergify bot commented Dec 13, 2023

This pull request does not have a backport label. Could you fix it @amannocci? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 13, 2023
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Unfortunately changing a heading is easier said than done. With this change, you'll need to update all links that point to apm-mutating-admission-webhook. In addition, we'll want to set up a redirect to catch any external links. The obs-docs team can help with the redirects. I recommend doing a ctrl+f for apm-mutating-admission-webhook and updating this PR accordingly.

@bmorelli25 bmorelli25 dismissed their stale review December 13, 2023 19:12

changes addressed in 11702a7

@amannocci amannocci enabled auto-merge (squash) December 26, 2023 11:24
@kruskall
Copy link
Member

@amannocci can you sign the initial commit ?

@amannocci amannocci force-pushed the chore/rename-apm-k8s branch 4 times, most recently from ea129d9 to 523e754 Compare December 28, 2023 12:44
amannocci and others added 2 commits December 28, 2023 13:44
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci amannocci force-pushed the chore/rename-apm-k8s branch from 523e754 to ec8a776 Compare December 28, 2023 12:44
@amannocci amannocci requested a review from bmorelli25 December 28, 2023 12:45
@amannocci amannocci merged commit c161dee into main Dec 28, 2023
9 of 10 checks passed
@amannocci amannocci deleted the chore/rename-apm-k8s branch December 28, 2023 13:00
v1v added a commit to v1v/apm-server that referenced this pull request Jan 10, 2024
* feature/patch-release: (249 commits)
  Update release.mk
  [updatecli] Bump elastic stack version to 8.13.0-8upz6ftd (elastic#12380)
  chore: Update to elastic/beats@95f0f85a3edd (elastic#12370)
  ci(release): automate release steps for the minor (elastic#12233)
  build(deps): bump the github-actions group with 1 update (elastic#12365)
  chore: Update to elastic/beats@d1b32774aef4 (elastic#12362)
  [updatecli] Bump elastic stack version to 8.13.0-ybxdr713 (elastic#12349)
  chore: Update to elastic/beats@81ebafc4c2da (elastic#12352)
  [apm docs consolidation] Delete moved files, update README (elastic#12341)
  [updatecli] Bump elastic stack version to 8.13.0-toucn398 (elastic#12325)
  docs: fix incorrect filenames in a document for Windows (elastic#12343)
  chore: Update to elastic/beats@6f192c01ef19 (elastic#12337)
  build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (elastic#12237)
  Update NOTICE.txt year (elastic#12333)
  build(deps): bump the github-actions group with 1 update (elastic#12322)
  [updatecli] Bump elastic stack version to 8.13.0-4f8l51qr (elastic#12315)
  docs: Update known issues as fix was released (elastic#12196)
  feat: use latest apm-data to set success `event.outcome` when otel span.Status is Unset (elastic#12199)
  [updatecli] Bump elastic stack version to 8.13.0-4aavtlfc (elastic#12304)
  chore: rename apm-mutating-webhook to apm-k8s-attacher (elastic#12222)
  ...
colleenmcginnis added a commit to colleenmcginnis/observability-docs that referenced this pull request Jan 12, 2024
colleenmcginnis added a commit to elastic/observability-docs that referenced this pull request Jan 12, 2024
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Jan 12, 2024
* copy over changes from elastic/apm-server#12343

* copy over changes from elastic/apm-server#12196

* copy over changes from elastic/apm-server#12222

(cherry picked from commit e691982)
colleenmcginnis added a commit to elastic/observability-docs that referenced this pull request Jan 12, 2024
…3542)

* copy over changes from elastic/apm-server#12343

* copy over changes from elastic/apm-server#12196

* copy over changes from elastic/apm-server#12222

(cherry picked from commit e691982)

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants