-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Rally track and tooling #6731
Conversation
23d0b74
to
7c549eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
I'll update this and merge it. We don't have to use it as it is, but we weren't using the old stuff either. Let's iterate. |
* Delete old stuff * Introduce our own requirements.txt * Introduce tooling for generating Rally corpora (cherry picked from commit 40aafab)
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
…ging * upstream/main: (25 commits) Update to elastic/beats@cb7e33d0864e (elastic#7672) Update backporting docs (elastic#7639) [Automation] Update elastic stack version to 8.2.0-dcff22d7 for testing (elastic#7670) Update aws-lambda-extension.asciidoc (elastic#7664) modelindexer: Reduce locking on flushActive (elastic#7649) dra: run release-manager if branch is available (elastic#7631) [apmpackage] add quotes around {{this}} (elastic#7598) dra: enforce version (elastic#7636) Update magefile for universal Darwin binaries (elastic#7643) Update to elastic/beats@2443dbb9e892 (elastic#7640) Update go.mod (elastic#7638) Introduce new Rally track and tooling (elastic#6731) dra: slack/email with the branch (elastic#7630) model/modelindexer: close gzip writer (elastic#7624) [Automation] Update elastic stack version to 8.2.0-4509f321 for testing (elastic#7620) Fix asciidoc hyperlink syntax (elastic#7609) Update to elastic/beats@f2ce0a0f69a5 (elastic#7618) ci: packaging pipeline should not notify build status in github comments (elastic#7596) docs: add 8.1.1 release notes (elastic#7601) Always set timestamp on APMEvents for incoming http requests (elastic#7567) ...
Removing from the test plan, this is not user facing. |
Motivation/summary
Remove outdated Rally track.
Introduce our own minimal Python requirements.txt. We install Rally (esrally) on-demand.
Introduce a new Rally track and tooling for generating Rally corpora, comprising:
rally/track.json
, a Rally track that references generated and .gitignored corpora inrally/corpora
.script/cat_bulk.py
, which runs apm-server configured to point at an in-memory fake Elasticsearch HTTP server that writes bulk requests out to stdout. Run this script, send events to the server as usual, and the resulting Elasticsearch documents will be sent to stdout.rally/gencorpora
, a Go program which provides a framework for generating Rally corpora using opentelemetry-go andscript/cat_bulk.py
.The Rally track does not install templates or ingest pipelines. It is currently assumed that the APM integration package is installed before running Rally races.
Two new Makefile targets are added:
make rally/corpora
(generate Rally corpora), andmake rally
(install esrally and run a race).Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
docker-compose up -d
make apm-server build-package
make rally
Related issues
See #6115