Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis output integration tests improvements #17181

Closed
urso opened this issue Mar 23, 2020 · 4 comments
Closed

Redis output integration tests improvements #17181

urso opened this issue Mar 23, 2020 · 4 comments
Labels

Comments

@urso
Copy link

urso commented Mar 23, 2020

The PR #16206 adds support for URL based redis host configurations. The PR already adds these tests:

  • integration tests for accessing redis with and without an URL schema
  • unit tests to verify schema, url, and password are parsed correctly.

The redis test container used for testing does not configure a password. That is the testsuite currently does not check if authentication is working correctly, no matter how the password was configured.

TODO:

  • setup containers with and without password (ensure we test both variants)
  • add integration test using the password setting
  • add integration test configuring an alternative password within the URL like redis://:<password>@<host>.
@urso urso added libbeat Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@andresrc andresrc added [zube]: Inbox [zube]: In Progress Team:Services (Deprecated) Label for the former Integrations-Services team and removed Team:Services (Deprecated) Label for the former Integrations-Services team libbeat [zube]: Inbox labels Apr 21, 2020
@botelastic
Copy link

botelastic bot commented Mar 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Mar 22, 2021
@urso urso removed the Stalled label Mar 23, 2021
@ph ph added Team:Elastic-Agent Label for the Agent team and removed Team:Services (Deprecated) Label for the former Integrations-Services team labels Apr 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic
Copy link

botelastic bot commented Apr 30, 2022

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 30, 2022
@botelastic botelastic bot closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants