-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick: #10030 and #9869 to 6.5: Handle IPv6 zone id in IIS filebeat ingest pipeline #10057
Conversation
…ingest pipeline (elastic#9933) IIS logs can include zone ids when using IPv6, this is correctly parsed but geoip processor doesn't accept these addresses. Create a temporary field without the zone id to be used by geoip processor. (cherry picked from commit d59ae8c) (cherry picked from commit 5f1f6ca)
… ingest pipeline for access logs too (elastic#10030) (cherry picked from commit e05f967)
Can you regenerate the golden files? Seem CI is not happy with this backport variant. |
Expected json is fine for the modified module, failing ones seem to be #9855, I'll backport this too to 6.5 so it goes back to green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM.
Should be good after rebasing over #10072
@jsoriano You're not forgetting about this, right? ;-) |
@webmat thanks for the ping ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…id in IIS filebeat ingest pipeline (elastic#10057) IIS logs can include zone ids when using IPv6, this is correctly parsed but geoip processor doesn't accept these addresses. Create a temporary field without the zone id to be used by geoip processor. (cherry picked from commit dad84e9) (cherry picked from commit 5f1f6ca) (cherry picked from commit e05f967) Co-authored-by: Mathieu Martin <webmat@gmail.com>
Cherry-pick of #10030 and #9869 to 6.5.