-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for new processors #11239
Add docs for new processors #11239
Conversation
This will close #10879. |
Add docs for add_fields, add_labels, and add_tags processors
6433b1e
to
7df9cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor editorial changes.
appended to the existing list of tags, if the target field already exists. | ||
|
||
`tags`:: List of tags to add | ||
`target`:: (Optional) Field the tags will be added to. Defaults to `tags`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an example that shows usage here.
Co-Authored-By: urso <steffen.siering@elastic.co>
number: 1 | ||
with.dots: test | ||
nested: | ||
with.dots: nested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we moving away from dots in field names, to avoid conceptual conflicts with dots representing nested objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add docs for add_fields, add_labels, and add_tags processors (cherry picked from commit 6872b33)
Cherry-pick of PR #11239 to 7.0 branch. Original message: Add docs for add_fields, add_labels, and add_tags processors
Add docs for add_fields, add_labels, and add_tags processors