Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for new processors #11239

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Add docs for new processors #11239

merged 3 commits into from
Mar 29, 2019

Conversation

urso
Copy link

@urso urso commented Mar 14, 2019

Add docs for add_fields, add_labels, and add_tags processors

@urso urso added docs review needs_backport PR is waiting to be backported to other branches. labels Mar 14, 2019
@urso urso requested a review from a team as a code owner March 14, 2019 01:23
@andrewkroh
Copy link
Member

andrewkroh commented Mar 14, 2019

This will close #10879.

@urso urso requested a review from dedemorton March 16, 2019 02:37
Add docs for add_fields, add_labels, and add_tags processors
@urso urso force-pushed the docs-new-processors branch from 6433b1e to 7df9cb3 Compare March 16, 2019 02:38
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor editorial changes.

libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/processors-using.asciidoc Outdated Show resolved Hide resolved
appended to the existing list of tags, if the target field already exists.

`tags`:: List of tags to add
`target`:: (Optional) Field the tags will be added to. Defaults to `tags`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an example that shows usage here.

dedemorton and others added 2 commits March 26, 2019 23:03
Co-Authored-By: urso <steffen.siering@elastic.co>
number: 1
with.dots: test
nested:
with.dots: nested
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we moving away from dots in field names, to avoid conceptual conflicts with dots representing nested objects?

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso urso merged commit 6872b33 into elastic:master Mar 29, 2019
urso pushed a commit to urso/beats that referenced this pull request Apr 2, 2019
Add docs for add_fields, add_labels, and add_tags processors

(cherry picked from commit 6872b33)
@urso urso added v7.0.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 2, 2019
urso pushed a commit that referenced this pull request Apr 3, 2019
Cherry-pick of PR #11239 to 7.0 branch. Original message: 

Add docs for add_fields, add_labels, and add_tags processors
@urso urso deleted the docs-new-processors branch May 9, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants