Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqs dashboard and add s3 dashboard image to doc #12015

Merged
merged 3 commits into from
May 29, 2019
Merged

Fix sqs dashboard and add s3 dashboard image to doc #12015

merged 3 commits into from
May 29, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 1, 2019

By looking at AWS SQS monitoring console for a specific queue, most of the metrics they are showing applies statistic method Sum.
Screen Shot 2019-05-01 at 12 37 02 PM
This is why I switched statistic method from average to sum in this PR.

Thanks @sayden for testing the sqs dashboard and found a bug in the filter section. This PR also fixed that.

Also s3 dashboard is added but not shown in the documentation. This PR adds the example dashboard into documentation as well.

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners May 1, 2019 18:25
@kaiyan-sheng
Copy link
Contributor Author

kaiyan-sheng commented May 1, 2019

Looking at various statistic method that AWS puts by default on their dashboards made me start thinking it might be useful to add a config option into aws module for different statistic methods when querying cloudwatch metrics. I will start an issue discussing this separately.

@kaiyan-sheng kaiyan-sheng self-assigned this May 1, 2019
@kaiyan-sheng kaiyan-sheng added Team:Integrations Label for the Integrations team review [zube]: In Review needs_backport PR is waiting to be backported to other branches. and removed needs_backport PR is waiting to be backported to other branches. labels May 1, 2019
@kaiyan-sheng kaiyan-sheng requested a review from sayden May 8, 2019 13:22
@sayden
Copy link
Contributor

sayden commented May 27, 2019

Getting this error when trying to open the dashboard. However I don't see anything wrong in the JSON file
image

@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. and removed [zube]: In Review review labels May 28, 2019
@kaiyan-sheng kaiyan-sheng added review and removed in progress Pull request is currently in progress. labels May 29, 2019
@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label May 29, 2019
@sayden sayden self-requested a review May 29, 2019 15:24
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. All dashboards ok 👍

@kaiyan-sheng
Copy link
Contributor Author

jenkins, test this please

@kaiyan-sheng kaiyan-sheng merged commit 5644e66 into elastic:master May 29, 2019
@kaiyan-sheng kaiyan-sheng deleted the fix_dashboards branch May 29, 2019 17:45
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label May 29, 2019
kaiyan-sheng added a commit that referenced this pull request May 29, 2019
* Fix sqs dashboard and add s3 dashboard image to doc
(cherry picked from commit 5644e66)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#12352)

* Fix sqs dashboard and add s3 dashboard image to doc
(cherry picked from commit a773f47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants