-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metricbeat]kubernetes kube-state-metrics service #14794
Merged
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c660744
start working on ksm service
odacremolbap 551fe8e
add ksm service
odacremolbap 2dd1100
add ingress fields
odacremolbap 86257cb
fix date format
odacremolbap c7df6b6
add docs changes
odacremolbap c13e6c0
Merge branch 'master' of github.com:elastic/beats into task/ksm-service
3fbd2c8
x-pack reference update
odacremolbap f9f724c
Merge branch 'master' into task/ksm-service
odacremolbap e521679
Merge branch 'master' of github.com:elastic/beats into task/ksm-service
451f197
Merge branch 'task/ksm-service' of github.com:odacremolbap/beats into…
b40cf2e
Merge branch 'master' of github.com:elastic/beats into task/ksm-service
9070ba1
Merge branch 'master' of github.com:elastic/beats into task/ksm-service
f339b04
replace ga with experimental
odacremolbap fd88608
Merge branch 'master' into task/ksm-service
odacremolbap 59ecbb5
remove non needed if block
odacremolbap b77e363
remove blank line
odacremolbap 4239c8f
Update metricbeat/module/kubernetes/state_service/README.md
odacremolbap 4c51e21
add description + example to new configuration options at prometheus …
odacremolbap 465482e
Merge branch 'task/ksm-service' of github.com:odacremolbap/beats into…
odacremolbap 0f74b36
I would say this looks a bit better
odacremolbap 91f30d2
Merge branch 'master' into task/ksm-service
odacremolbap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
//// | ||
This file is generated! See scripts/mage/docs_collector.go | ||
//// | ||
|
||
[[metricbeat-metricset-kubernetes-state_service]] | ||
=== Kubernetes state_service metricset | ||
|
||
experimental[] | ||
|
||
include::../../../module/kubernetes/state_service/_meta/docs.asciidoc[] | ||
|
||
|
||
==== Fields | ||
|
||
For a description of each field in the metricset, see the | ||
<<exported-fields-kubernetes,exported fields>> section. | ||
|
||
Here is an example document generated by this metricset: | ||
|
||
[source,json] | ||
---- | ||
include::../../../module/kubernetes/state_service/_meta/data.json[] | ||
---- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that we by-pass the mapping https://github.com/elastic/beats/pull/14794/files#diff-dec796600491bdd3547c0d5777fb1ea6R31?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this means that if
StoreNonMappedLabels
is set to true, and there is a metric family that contains labels whose names are not known beforehand but we are interested in pushing with our events, they will be added, and placed under the location ofNonMappedLabelsPlacement
By your comment it looks like this is not clear and that I should rethink.
Would a comment like:
please, propose/modify which whatever you find would be clarifying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, got it now! I think it will be helpful if we add an example here showing the expected output. I see nice "examples" in the unit-tests, how about adding one in this docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrsMark updated