[libbeat] Remove global loggers from libbbeat/dashboard #18541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
urso
reviewed
May 15, 2020
urso
reviewed
May 18, 2020
libbeat/dashboards/kibana_loader.go
Outdated
| @@ -153,6 +157,6 @@ func (loader KibanaLoader) statusMsg(msg string, a ...interface{}) { | |||
| if loader.msgOutputter != nil { | |||
| loader.msgOutputter(msg, a...) | |||
| } else { | |||
| logp.Debug("dashboards", msg, a...) | |||
| loader.defaultLogger.Debugf("%s %v", msg, a) | |||
There was a problem hiding this comment.
the old implementation looks like "statusMsg" implements a Printf like interface (better named would have been statusMsgf.
s/loader.defaultLogger.Debugf("%s %v", msg, a)/loader.defaultLogger.debugf(msg, a...)/
Is MsgOutputer used somewhere? It kind of looks like a 'duplicate' interface for logging.
There was a problem hiding this comment.
Yah, it was one of those things where whatever calls the loader also asks for that message handler option, so it seems to go fairly high up the call stack and I was hesitant to mess with it.
There was a problem hiding this comment.
I see.
Let's change this line to this (to restore the behavior from before this PR):
loader.defaultLogger.Debugf(msg, a...)
urso
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See #18500 for the meta-issue. This remove any global loggers. I was a tad hesitant to turn "soft" errors into hard errors, so I worked around some of the error handling for the sake of not breaking anything. This still technically contains "breaking" changes, so not sure if we wanna backport it.
Why is it important?
We want to remove the global logger from libbeat.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.