Cherry-pick #18817 to 7.x: Upgrade k8s.io/client-go and k8s keystore tests #18879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18817 to 7.x branch. Original message:
What does this PR do?
This PR is a follow up for #18096.
Aims to add tests for k8s keystore internal functionality using a fake client for retrieving k8s secrets. An upgrade of
k8s.io/client-go
is needed in order to make use of thefake
client (https://github.com/kubernetes/client-go/releases/tag/v0.18.3, https://pkg.go.dev/k8s.io/client-go@v0.18.3/kubernetes?tab=doc).Upgrade procedure:
Changes:
k8s.io/client-go
kube-state-metrics
in order to avoid flakinessWhy is it important?
In order to cover k8s keystore
Retrieve
functionality.