[Packetbeat][SIP] Fix function that parses from/to/contact headers #21672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
marc-gr
force-pushed
the
sip_fix_parser
branch
from
054a25c
to
7018155
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
added
review
and removed
in progress
andrewkroh
approved these changes
Oct 8, 2020
andrewkroh
added
the
needs_backport
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Oct 8, 2020
(cherry picked from commit 2d2c4c3)
marc-gr
added
v7.11.0
and removed
needs_backport
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Oct 8, 2020
(cherry picked from commit 2d2c4c3)
3 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 8, 2020
…012-2.0 * upstream/master: Fix function that parses from/to/contact headers (elastic#21672) [CI] Support Windows-2016 in pipeline 2.0 (elastic#21337)
andrewkroh
pushed a commit
that referenced
this pull request
Oct 8, 2020
marc-gr
added a commit
that referenced
this pull request
Oct 9, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 13, 2020
* upstream/master: (127 commits) Update obs app links (elastic#21682) fix: update fleet test suite name (elastic#21738) Remove dot from file.extension value in Auditbeat FIM (elastic#21644) Fix leaks with metadata processors (elastic#16349) Add istiod metricset (elastic#21519) [Ingest Manager] Change Sync/Close call order (elastic#21735) [Ingest Manager] Syncing unpacked files (elastic#21706) Fix concurrent map read and write in socket dataset (elastic#21690) Fix conditional coding to remove seccomp info from Winlogbeat (elastic#21652) [Elastic Agent] Fix issue where inputs without processors defined would panic (elastic#21628) Add configuration of filestream input (elastic#21565) libbeat/logp: introduce Logger.WithOptions (elastic#21671) Make o365audit input cancellable (elastic#21647) fix: remove extra curly brace in script (elastic#21692) [Winlogbeat] Remove brittle configuration validation from wineventlog (elastic#21593) Fix function that parses from/to/contact headers (elastic#21672) [CI] Support Windows-2016 in pipeline 2.0 (elastic#21337) Skip publisher flaky tests (elastic#21657) backport: add 7.10 branch (elastic#21635) [CI: Packaging] fix: push ubi8 images too (elastic#21621) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the function that parses
from/to/contactheaders in SIP protoWhy is it important?
When the header comes without display info and the URI is not wrapped by
<...>it was causing an out of bounds error.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues