[Metricbeat] gcp: log metrics without descriptors #26982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endorama
added
enhancement
Team:Integrations
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Metrics listed in the light-weight modules are checked with GCP Stackdriver APIs to gather further information about them. In case the metric is not valid, the request to the API returns an empty response and the metric in question is excluded from collection. There is no error returned from APIs. In such a case a log line at error level is produced, notifying the user of the wrong behaviour.
endorama
force-pushed
the
gcp-refactor-metric-without-descriptors
branch
from
b895204
to
67bbc70
Compare
|
Pinging @elastic/integrations (Team:Integrations) |
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
Metrics listed in the light-weight modules are checked with GCP Stackdriver APIs to gather further information about them. In case the metric is not valid, the request to the API returns an empty response and the metric in question is excluded from collection. There is no error returned from APIs. In such a case a log line at error level is produced, notifying the user of the wrong behaviour. (cherry picked from commit 452f0fa)
endorama
added a commit
that referenced
this pull request
Aug 4, 2021
…ors (#27227) Metrics listed in the light-weight modules are checked with GCP Stackdriver APIs to gather further information about them. In case the metric is not valid, the request to the API returns an empty response and the metric in question is excluded from collection. There is no error returned from APIs. In such a case a log line at error level is produced, notifying the user of the wrong behaviour. (cherry picked from commit 452f0fa) Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an error log statement reporting metrics for which GCP Monitoring APIs report no metric descriptors.
Why is it important?
Before metric collection, the
gcpmodule request metric descriptors for all metrics specified in the fields file.Is possible that the GCP Monitoring API return an empty metric descriptor set, upon request. The most probable reason is due to the metric being not found.
The current behaviour for these occurrences is to ignore the metric and proceed. This silently discard a requested metric without any visible output to the developer/operator, and I consider it a bad developer experience.
I don't consider this behaviour a fatal error, but surely worthy to be reported as error in the logs.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs