-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Python tests in libbeat #28438
Merged
Merged
Run Python tests in libbeat #28438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 14, 2021
This pull request does not have a backport label. Could you fix it @kvch? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Oct 14, 2021
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 14, 2021
kvch
added
backport-v7.15.0
Automated backport with mergify
backport-v7.16.0
Automated backport with mergify
labels
Oct 14, 2021
mergify
bot
removed
the
backport-skip
Skip notification from the automated backport with mergify
label
Oct 14, 2021
kvch
changed the title
Move running Python tests from x-pack/libbeat to libbeat
Run Python tests in libbeat
Oct 14, 2021
v1v
approved these changes
Oct 14, 2021
Collaborator
The tests are failing because fields.yml file is not generated for the mockbeat. |
kvch
force-pushed
the
test-libbeat-run-python-tests
branch
from
October 15, 2021 09:24
b3b02ac
to
5436ebf
Compare
WFG |
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
(cherry picked from commit ce29bea)
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
(cherry picked from commit ce29bea)
kvch
added a commit
that referenced
this pull request
Oct 18, 2021
kvch
added a commit
that referenced
this pull request
Oct 18, 2021
v1v
added a commit
that referenced
this pull request
Oct 18, 2021
* upstream/7.x: chore: use same branching schema for e2e (#28493) [Automation] Update elastic stack version to 7.16.0-8bf0b9b1 for testing (#28484) chore(ci): remove not used param when triggering e2e tests (#27823) (#27828) Add deprecation warning for filebeat disabled modules (#28393) Run Python tests in libbeat (#28438) (#28485) Register `storage_account` as second name for `storage` metricset (#28447) (#28470) [CI] Add E2E for x-pack/elastic-agent (fleet) (#24112) (#28465)
v1v
added a commit
that referenced
this pull request
Oct 18, 2021
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v7.15.0
Automated backport with mergify
backport-v7.16.0
Automated backport with mergify
Team:Automation
Label for the Observability productivity team
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds running Python tests to libbeat.
Why is it important?
x-pack/libbeat does not contain any tests. All the job does is setup the environment, build a mockbeat, print "no tests found" and reports success. All E2E tests are located under libbeat and those haven't been run since forever... 🤦
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.