Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Python tests in libbeat #28438

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Oct 14, 2021

What does this PR do?

This PR adds running Python tests to libbeat.

Why is it important?

x-pack/libbeat does not contain any tests. All the job does is setup the environment, build a mockbeat, print "no tests found" and reports success. All E2E tests are located under libbeat and those haven't been run since forever... 🤦

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

This pull request does not have a backport label. Could you fix it @kvch? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 14, 2021
@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2021
@kvch kvch added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Oct 14, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 14, 2021
@jsoriano jsoriano added the Team:Automation Label for the Observability productivity team label Oct 14, 2021
@kvch kvch changed the title Move running Python tests from x-pack/libbeat to libbeat Run Python tests in libbeat Oct 14, 2021
@kvch kvch self-assigned this Oct 14, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 157 min 54 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@kvch
Copy link
Contributor Author

kvch commented Oct 14, 2021

The tests are failing because fields.yml file is not generated for the mockbeat.

@kvch kvch force-pushed the test-libbeat-run-python-tests branch from b3b02ac to 5436ebf Compare October 15, 2021 09:24
@kvch
Copy link
Contributor Author

kvch commented Oct 15, 2021

WFG

@kvch kvch merged commit ce29bea into elastic:master Oct 18, 2021
mergify bot pushed a commit that referenced this pull request Oct 18, 2021
(cherry picked from commit ce29bea)
mergify bot pushed a commit that referenced this pull request Oct 18, 2021
(cherry picked from commit ce29bea)
kvch added a commit that referenced this pull request Oct 18, 2021
(cherry picked from commit ce29bea)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch added a commit that referenced this pull request Oct 18, 2021
(cherry picked from commit ce29bea)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
v1v added a commit that referenced this pull request Oct 18, 2021
* upstream/7.x:
  chore: use same branching schema for e2e (#28493)
  [Automation] Update elastic stack version to 7.16.0-8bf0b9b1 for testing (#28484)
  chore(ci): remove not used param when triggering e2e tests (#27823) (#27828)
  Add deprecation warning for filebeat disabled modules (#28393)
  Run Python tests in libbeat (#28438) (#28485)
  Register `storage_account` as second name for `storage` metricset  (#28447) (#28470)
  [CI] Add E2E for x-pack/elastic-agent (fleet) (#24112) (#28465)
v1v added a commit that referenced this pull request Oct 18, 2021
…28481

* upstream/7.15:
  chore(ci): remove not used param when triggering e2e tests (#27823) (#27830)
  Run Python tests in libbeat (#28438) (#28486)
  [CI] Add E2E for x-pack/elastic-agent (fleet) (#24112) (#28466)
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants