Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert usageDetails api version to 2019-01-01 #28995

Merged
merged 7 commits into from
Nov 17, 2021
Merged

Revert usageDetails api version to 2019-01-01 #28995

merged 7 commits into from
Nov 17, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Nov 16, 2021 •
edited
Loading

What does this PR do?

Revert usageDetails api version to 2019-01-01

Current version 2019-10-01 times out and filtering by date does not work anymore. Reverted back to 2019-01-01 everything looks fine

Why is it important?

Current version 2019-10-01 times out and filtering by date does not work anymore. Reverted back to 2019-01-01 everything looks fine.
Also removed unused consumption clients and updated sdk.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

This pull request does not have a backport label. Could you fix it @narph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-billing-old upstream/fix-billing-old
git merge upstream/master
git push upstream fix-billing-old

@narph narph added backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 16, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 16, 2021
@narph narph added backport-skip Skip notification from the automated backport with mergify Team:Integrations Label for the Integrations team labels Nov 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@narph narph self-assigned this Nov 16, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 16, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 16, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-16T16:12:45.082+0000

  • Duration: 228 min 29 sec

  • Commit: 0136eab

Test stats 🧪

Test Results
Failed 0
Passed 54050
Skipped 5323
Total 59373

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@endorama
Copy link
Member

Are there integration tests covering this that we can run?

@narph
Copy link
Contributor Author

narph commented Nov 16, 2021

Are there integration tests covering this that we can run?

In the backlog #17707

@narph narph merged commit 77346be into elastic:master Nov 17, 2021
@narph narph deleted the fix-billing-old branch November 17, 2021 08:34
mergify bot pushed a commit that referenced this pull request Nov 17, 2021
@narph
Revert usageDetails api version to 2019-01-01 (#28995)
3dc6c19 
* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt

(cherry picked from commit 77346be)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Nov 17, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 17, 2021
@narph
Revert usageDetails api version to 2019-01-01 (#28995)
de16dcf 
* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt

(cherry picked from commit 77346be)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Nov 17, 2021
Merged
narph added a commit that referenced this pull request Nov 17, 2021
@narph
Revert usageDetails api version to 2019-01-01 (#28995)
93f1e57 
* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt
narph added a commit that referenced this pull request Nov 17, 2021
@narph
Revert usageDetails api version to 2019-01-01 (#28995)
a617fee 
* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt
narph added a commit that referenced this pull request Nov 17, 2021
@mergify @narph
[7.16](backport #28995) Revert usageDetails api version to 2019-01-01 (…
b119cff 
…#29011)

* Revert usageDetails api version to 2019-01-01 (#28995)

* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt

(cherry picked from commit 77346be)

# Conflicts:
#	go.sum

* Revert usageDetails api version to 2019-01-01 (#28995)

* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt

Co-authored-by: Mariana Dima <mariana@elastic.co>
narph added a commit that referenced this pull request Nov 17, 2021
@mergify @narph
[8.0](backport #28995) Revert usageDetails api version to 2019-01-01 (#…
e493703 
…29012)

* Revert usageDetails api version to 2019-01-01 (#28995)

* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt

(cherry picked from commit 77346be)

# Conflicts:
#	go.sum

* Revert usageDetails api version to 2019-01-01 (#28995)

* fix billing

* changelog

* fix test

* fix test

* fmt update

* fmt

Co-authored-by: Mariana Dima <mariana@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

Assignees

@narph narph

Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @endorama