-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x](backport #41222) Switch K8s tests to Wolfi by default and make it configurable #41237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we test Wolfi-based images but there is now an environment variable `IMAGE_MODIFIER` that can be used for specifying different image prefixes when calling the make target. Also, now the test verifies the actual container readiness and deletes resources after itself. (cherry picked from commit 3492089) # Conflicts: # deploy/kubernetes/auditbeat-kubernetes.yaml # deploy/kubernetes/filebeat-kubernetes.yaml # deploy/kubernetes/heartbeat-kubernetes.yaml # deploy/kubernetes/metricbeat-kubernetes.yaml
mergify
bot
added
backport
conflicts
There is a conflict in the backported pull request
labels
Oct 15, 2024
mergify
bot
requested review from
mauri870 and
faec
and removed request for
a team
October 15, 2024 13:42
mergify
bot
requested review from
tetianakravchenko and
constanca-m
and removed request for
a team
October 15, 2024 13:42
Cherry-pick of 3492089 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 15, 2024
This pull request doesn't have a |
rdner
approved these changes
Oct 15, 2024
rdner
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
conflicts
There is a conflict in the backported pull request
needs_team
Indicates that the issue/PR needs a Team:* label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
By default we test Wolfi-based images but there is now an environment variable
IMAGE_MODIFIER
that can be used for specifying different image prefixes when calling the make target.Also, now the test verifies the actual container readiness and deletes resources after itself.
How to test this PR locally
Run the packaging command in the following folders:
(put your architecture instead)
Then you need a running K8s cluster with the pre-configured
kubectl
. I used Docker Desktop.then go to
./deploy/kubernetes
and runby default we test against the Wolfi-based images but it can be switched by:
or test the main image instead:
The output should be something like this:
This means K8s manifests were successfully generated, applied and the containers were running successfully.
Check the generated manifests for the images to have
-wolfi
suffix:Related issues
This is an automatic backport of pull request #41222 done by [Mergify](https://mergify.com).