Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that wrong config panics http metricsets #6205

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Fix issue that wrong config panics http metricsets #6205

merged 1 commit into from
Jan 31, 2018

Commits on Jan 31, 2018

  1. Fix issue that wrong config panice http metricsets 

    When setting an invalide http config in a metricbeat module / metricset it could happen that the metricset paniced. The reason is that the error when unpacking the config was not properly returned and handled which lead to an empty http instance.

This PR changes the behaviour to return the errors which can then be handled by the metricsets. The issue also affects all metricsets which were based on the prometheus helper.

Closes elastic#6192
    @ruflin
    ruflin committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    69deda7 View commit details
    Browse the repository at this point in the history