Cherry-pick #6130 to 6.2: Change kubernetes.node.cpu.allocatable.cores to float #6709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
backport_6130_6.2
branch
from
784b7bb to
f6f3cbe
Compare
Closes elastic#6123 (cherry picked from commit edb5a91)
|
Could we have used |
jsoriano
approved these changes
Apr 3, 2018
|
@jsoriano Probably yes. I'm hesitant to change it in the backport but then would rather merge this one, open a second PR against master and backport this too. I wonder if we should treat float to scaled_float as a breaking change. In general I would say no, so we go have |
|
Ok, merging this then |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Closes elastic#6123 (cherry picked from commit edb5a91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #6130 to 6.2 branch. Original message:
Closes #6123