Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kafka 1.0.0 and 1.1.0 to kafka metricbeat module #6823

Closed
wants to merge 1 commit into from

Conversation

filipecosta90
Copy link

Add support for Kafka 1.0.0 and 1.1.0 to kafka metricbeat module

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin
Copy link
Member

ruflin commented Apr 13, 2018

@filipecosta90 Thanks for taking this on. I think it's good to add these new versions to the file to start testing against these version. To make it clear for others coming to this issue, having these version in there does not automatically mean we support all of them as we first need to get the testing in place to verify it works.

@urso I wonder if these versions also have to be added somewhere in the output? https://github.com/elastic/beats/blob/master/libbeat/outputs/kafka/kafka.go#L66 Interestingly the two files are already now out of sync. Should we sync them up?

@urso
Copy link

urso commented Aug 2, 2018

The kafka output and metricbeat kafka module have some duplicated out-of-sync definitions/code here. We should unify some functionality in a libbeat/net/kafka package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants