Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdx → asciidoc] Add AsciiDoc serverless files #168

Merged
merged 26 commits into from
Nov 5, 2024
Merged

[mdx → asciidoc] Add AsciiDoc serverless files #168

merged 26 commits into from
Nov 5, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Nov 4, 2024 •
edited
Loading

Related to elastic/docs#3096

I did a full review where I looked at:

  • The diff between the MDX and AsciiDoc file for each page and confirmed that the only changes were to the syntax.
  • The rendered result of the both the MDX version and AsciiDoc version of each page side-by-side and confirmed that they result in the same structure.

This PR adds AsciiDoc files and images to replace DocIcon. A few MDX files are edited where the MDX syntax was incorrect. MDX files will be deleted in a follow-up PR.

You can see the result in this preview: https://docs_bk_3096.docs-preview.app.elstc.co/guide/en/serverless/current/intro.html

colleenmcginnis and others added 21 commits October 29, 2024 08:53
@colleenmcginnis
migrate mdx to asciidoc
19d80fd
@colleenmcginnis
hard code stack version
8d5f174
@colleenmcginnis
try including shared attributes using asciidoc-dir
523353e
@colleenmcginnis
clean up landing page, add project-settings, add badges, replace doc …
238a45f 
…related articles
@colleenmcginnis
fix broken link
3d68b2d
@colleenmcginnis
clean up links
67ad197
@colleenmcginnis
fix attributes in parentheses
eb30b76
@colleenmcginnis
add missing attributes
0415437
@colleenmcginnis
fix cloud regions page
3b99300
@colleenmcginnis
fix connections page, add missing security pages
fda4729
@colleenmcginnis
qa general
bfa6532
@colleenmcginnis
qa elasticsearch
6738c08
@colleenmcginnis
qa devtools
54e6992
@colleenmcginnis
qa project-settings
742d2dc
@colleenmcginnis
qa hidden pages
246642b
@colleenmcginnis
simplify landing page
0ac6708
@colleenmcginnis
Fix MDX syntax, broken links, and use of updated variables (#159)
50d7a5f 
* fix mdx syntax and links

* fix duplicate Elastic
@colleenmcginnis
Merge branch 'main' into mdx-to-asciidoc
d23fae4
@colleenmcginnis
clean post rebase and qa
c17e46f
@colleenmcginnis
restructure index
0ead907
@colleenmcginnis
update readme
5b5f674
@colleenmcginnis colleenmcginnis self-assigned this Nov 4, 2024
@elasticdocs
Copy link
Collaborator

elasticdocs commented Nov 4, 2024 •
edited
Loading

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@bmorelli25
Copy link
Member

run docs-build

@colleenmcginnis colleenmcginnis marked this pull request as ready for review November 5, 2024 16:03
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 5, 2024 16:03
georgewallace
georgewallace approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@georgewallace georgewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed preview and every page renders.

@colleenmcginnis colleenmcginnis merged commit 80ba445 into main Nov 5, 2024
2 checks passed
@bmorelli25 bmorelli25 deleted the mdx-to-asciidoc branch November 5, 2024 18:52
@colleenmcginnis colleenmcginnis mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgewallace georgewallace georgewallace approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@colleenmcginnis colleenmcginnis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colleenmcginnis @elasticdocs @bmorelli25 @georgewallace