enhancement(6394): remove unnecessary comments, refactor unused function

Author: kaanyalti

pkg/testing/fixture_install.go

@@ -470,7 +470,7 @@ func (f *Fixture) simpleInstallRPM(ctx context.Context) ([]byte, error) {
 		return out, fmt.Errorf("apt install failed: %w output:%s", err, string(out))
 	}
 
-	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock" // Why does controlSocketRunSylink not work here?
+	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock"
 	c := client.New(client.WithAddress(socketPath))
 	f.setClient(c)
 	return nil, nil
@@ -490,7 +490,7 @@ func (f *Fixture) simpleInstallDeb(ctx context.Context) ([]byte, error) {
 		return out, fmt.Errorf("apt install failed: %w output:%s", err, string(out))
 	}
 
-	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock" // Why does controlSocketRunSylink not work here?
+	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock"
 	c := client.New(client.WithAddress(socketPath))
 	f.setClient(c)
 
@@ -550,7 +550,7 @@ func (f *Fixture) installDeb(ctx context.Context, installOpts *InstallOpts, shou
 		return out, fmt.Errorf("systemctl start elastic-agent failed: %w", err)
 	}
 
-	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock" // Why does controlSocketRunSylink not work here?
+	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock"
 	c := client.New(client.WithAddress(socketPath))
 	f.setClient(c)
 
@@ -641,7 +641,7 @@ func (f *Fixture) installRpm(ctx context.Context, installOpts *InstallOpts, shou
 		return out, fmt.Errorf("systemctl start elastic-agent failed: %w", err)
 	}
 
-	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock" // Why does controlSocketRunSylink not work here?
+	socketPath := "unix:///var/lib/elastic-agent/elastic-agent.sock"
 	c := client.New(client.WithAddress(socketPath))
 	f.setClient(c)
 

testing/integration/endpoint_security_test.go

@@ -350,12 +350,6 @@ func installSecurityAgent(ctx context.Context, t *testing.T, info *define.Info,
 	fixture, err := define.NewFixtureFromLocalBuild(t, define.Version())
 	require.NoError(t, err, "could not create agent fixture")
 
-	policyResp := installSecurityAgentWithFixture(ctx, t, info, fixture, protected)
-
-	return fixture, policyResp
-}
-
-func installSecurityAgentWithFixture(ctx context.Context, t *testing.T, info *define.Info, fixture *atesting.Fixture, protected bool) kibana.PolicyResponse {
 	t.Log("Enrolling the agent in Fleet")
 	policyUUID := uuid.Must(uuid.NewV4()).String()
 
@@ -378,10 +372,11 @@ func installSecurityAgentWithFixture(ctx context.Context, t *testing.T, info *de
 		Privileged:     true,
 	}
 
-	policy, err := tools.InstallAgentWithPolicy(ctx, t,
+	policyResp, err := tools.InstallAgentWithPolicy(ctx, t,
 		installOpts, fixture, info.KibanaClient, createPolicyReq)
 	require.NoError(t, err, "failed to install agent with policy")
-	return policy
+
+	return fixture, policyResp
 }
 
 // buildPolicyWithTamperProtection helper function to build the policy request with or without tamper protection