[9.0](backport #6735) Clean up message when audit/uninstall returns 401 #6769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean up message when audit/uninstall returns 401 * Update internal/pkg/agent/install/uninstall.go Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> (cherry picked from commit c82d568)
mergify
bot
requested review from
andrzej-stencel and
kaanyalti
and removed request for
a team
github-actions
bot
added
bug
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
michel-laterman
approved these changes
Feb 7, 2025
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏 |
1 similar comment
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏 |
andrzej-stencel
approved these changes
Feb 18, 2025
|
kaanyalti
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clean up cli output when
elastic-agent uninstallruns when the agent has previously been unenrolled.Why is it important?
Current output indicates an error state, this can lead to confusion.
New output will indicate that the notification is dropped.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
N/A
How to test this PR locally
Unenroll an agent in fleet, then run the uninstall command.
Related issues
Invalid api keyerror is observed in CLI on running uninstall command for unenrolled agent. #6711This is an automatic backport of pull request #6735 done by [Mergify](https://mergify.com).