Skip to content

Conversation

@anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Jun 6, 2025

What does this PR do?

Adds cumulativetodeltaprocessor to the EDOT collector

elastic-agent version of elastic/opentelemetry-collector-components#601

/cc @codefromthecrypt

Why is it important?

Elastic stack only supports delta metrics. The processor can be used to still ingest certain cumulative metrics such as those scraped from Prometheus endpoints.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Can start a server exposing Prometheus metrics such as envoy and configure collector with prometheus receiver and cumulativetodelta processor to elastic apm.

@anuraaga anuraaga requested a review from a team as a code owner June 6, 2025 02:36
@anuraaga anuraaga added the enhancement New feature or request label Jun 6, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2025

This pull request does not have a backport label. Could you fix it @anuraaga? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@anuraaga anuraaga added the backport-active-all Automated backport with mergify to all the active branches label Jun 6, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cumulativetodelta upstream/cumulativetodelta
git merge upstream/main
git push upstream cumulativetodelta

@swiatekm swiatekm requested a review from a team June 6, 2025 08:54
Copy link
Contributor

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've allowed myself to add tests and update the changelog fragment.

@elastic-sonarqube
Copy link

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @anuraaga

@codefromthecrypt codefromthecrypt merged commit 5111970 into elastic:main Jun 6, 2025
11 checks passed
@codefromthecrypt
Copy link
Contributor

thanks @anuraaga!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2025

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 6, 2025
---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)

# Conflicts:
#	NOTICE-fips.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/components.go
#	internal/pkg/otel/testdata/all-components-fips.yml
mergify bot pushed a commit that referenced this pull request Jun 6, 2025
---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)

# Conflicts:
#	NOTICE-fips.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/testdata/all-components-fips.yml
mergify bot pushed a commit that referenced this pull request Jun 6, 2025
---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)
mergify bot pushed a commit that referenced this pull request Jun 6, 2025
---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)

# Conflicts:
#	NOTICE-fips.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/testdata/all-components-fips.yml
andrzej-stencel added a commit that referenced this pull request Jun 9, 2025
---------


(cherry picked from commit 5111970)

Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel pushed a commit that referenced this pull request Jun 9, 2025
…collector (#8385)

* otel: add cumulativetodeltaprocessor to EDOT collector (#8372)

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)

# Conflicts:
#	NOTICE-fips.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/components.go
#	internal/pkg/otel/testdata/all-components-fips.yml

* Fix merge

* Fix merge more

---------

Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
michel-laterman pushed a commit to michel-laterman/elastic-agent that referenced this pull request Jun 9, 2025
---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel added a commit that referenced this pull request Jun 10, 2025
…collector (#8386)

* otel: add cumulativetodeltaprocessor to EDOT collector (#8372)

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)

# Conflicts:
#	NOTICE-fips.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/testdata/all-components-fips.yml

* Fix merge

* mage notice

---------

Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel pushed a commit that referenced this pull request Jun 10, 2025
…ollector (#8388)

* otel: add cumulativetodeltaprocessor to EDOT collector (#8372)

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
(cherry picked from commit 5111970)

# Conflicts:
#	NOTICE-fips.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/testdata/all-components-fips.yml

* Fix merge

* Remove non-existing

---------

Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
v1v added a commit that referenced this pull request Jun 12, 2025
…ts-oblt-cli

* feature/serverless-its-oblt-cli: (51 commits)
  as agreed let's move the group to the kb.integration pipeline
  Update .github/workflows/serverless-project.yml
  ci: invoke serverless integration tests package from BK
  github-actions: create a serverless project daily
  [tests] split up serverless and resource leaks integration tests (#8396)
  chore: Update to elastic/beats@dfdc12e33de0 (#8446)
  Lock upgrade marker (#8254)
  build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.12 to 0.11.13 (#8420)
  Add docker image name template and renamed fips cloud specs (#8429)
  buildkite(scripts): refactor common scripts (#8365)
  Use require.Eventually to try and address flakiness (#8421)
  Fix pre-command to support extended testing (#8418)
  [Automation] Bump Golang version to 1.24.4 (#8384)
  chore: Update to elastic/beats@aed2a8b768bd (#8423)
  [main][Automation] Update versions (#8425)
  Add Pipeline to deploy custom agent image for FIPS testing (#8035)
  ci: automatically update OTel components (#8288)
  [Automation] Bump VM Image version to 1749258065 (#8390)
  fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault (#8374)
  otel: add cumulativetodeltaprocessor to EDOT collector (#8372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants