TestFIPSAgentConnectingToFIPSFleetServerInECHFRH : Use require.Eventually to try and address flakiness
#8421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
Contributor
Author
|
Looks like the FIPS integration tests passed without retries: https://buildkite.com/elastic/elastic-agent/builds/22082. Re-running to check for flakiness. |
Contributor
Author
|
buildkite test this |
ycombinator
requested review from
blakerouse,
michel-laterman and
swiatekm
and removed request for
blakerouse
ycombinator
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
Author
|
buildkite test this |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @ycombinator |
Contributor
Author
|
buildkite test this |
|
swiatekm
approved these changes
Jun 10, 2025
Contributor
Author
|
@Mergifyio backport 8.19 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
(cherry picked from commit 540ee8d) # Conflicts: # testing/integration/fleetserver_fips_test.go
Contributor
✅ Backports have been created
|
ycombinator
added a commit
that referenced
this pull request
Jun 10, 2025
(cherry picked from commit 540ee8d)
ycombinator
added a commit
that referenced
this pull request
Jun 10, 2025
v1v
added a commit
that referenced
this pull request
Jun 12, 2025
…ts-oblt-cli * feature/serverless-its-oblt-cli: (51 commits) as agreed let's move the group to the kb.integration pipeline Update .github/workflows/serverless-project.yml ci: invoke serverless integration tests package from BK github-actions: create a serverless project daily [tests] split up serverless and resource leaks integration tests (#8396) chore: Update to elastic/beats@dfdc12e33de0 (#8446) Lock upgrade marker (#8254) build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.12 to 0.11.13 (#8420) Add docker image name template and renamed fips cloud specs (#8429) buildkite(scripts): refactor common scripts (#8365) Use require.Eventually to try and address flakiness (#8421) Fix pre-command to support extended testing (#8418) [Automation] Bump Golang version to 1.24.4 (#8384) chore: Update to elastic/beats@aed2a8b768bd (#8423) [main][Automation] Update versions (#8425) Add Pipeline to deploy custom agent image for FIPS testing (#8035) ci: automatically update OTel components (#8288) [Automation] Bump VM Image version to 1749258065 (#8390) fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault (#8374) otel: add cumulativetodeltaprocessor to EDOT collector (#8372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR amends the
TestFIPSAgentConnectingToFIPSFleetServerInECHFRHintegration test to wrap the flaky assertion and it's pre-requisite code in arequire.Eventuallyblock.Why is it important?
To avoid flakiness in the test.
Related issues
Closes #8419