From 601b99a1f3502ae4544ef14b8356a93969ab6d8b Mon Sep 17 00:00:00 2001 From: michel-laterman Date: Thu, 12 Jun 2025 09:41:28 -0600 Subject: [PATCH] Change diagnostics action to use paths.TempDir --- ...paths.TempDir-for-diagnostics-actions.yaml | 32 +++++++++++++++++++ .../handlers/handler_action_diagnostics.go | 2 +- 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 changelog/fragments/1749742685-Use-paths.TempDir-for-diagnostics-actions.yaml diff --git a/changelog/fragments/1749742685-Use-paths.TempDir-for-diagnostics-actions.yaml b/changelog/fragments/1749742685-Use-paths.TempDir-for-diagnostics-actions.yaml new file mode 100644 index 00000000000..1eee16b3534 --- /dev/null +++ b/changelog/fragments/1749742685-Use-paths.TempDir-for-diagnostics-actions.yaml @@ -0,0 +1,32 @@ +# Kind can be one of: +# - breaking-change: a change to previously-documented behavior +# - deprecation: functionality that is being removed in a later release +# - bug-fix: fixes a problem in a previous version +# - enhancement: extends functionality but does not break or fix existing behavior +# - feature: new functionality +# - known-issue: problems that we are aware of in a given version +# - security: impacts on the security of a product or a user’s deployment. +# - upgrade: important information for someone upgrading from a prior version +# - other: does not fit into any of the other categories +kind: bug-fix + +# Change summary; a 80ish characters long description of the change. +summary: Use paths.TempDir for diagnostics actions + +# Long description; in case the summary is not enough to describe the change +# this field accommodate a description without length limits. +# NOTE: This field will be rendered only for breaking-change and known-issue kinds at the moment. +#description: + +# Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. +component: elastic-agent + +# PR URL; optional; the PR number that added the changeset. +# If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. +# NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. +# Please provide it if you are adding a fragment for a different PR. +pr: https://github.com/elastic/elastic-agent/pull/8472 + +# Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of). +# If not present is automatically filled by the tooling with the issue linked to the PR number. +#issue: https://github.com/owner/repo/1234 diff --git a/internal/pkg/agent/application/actions/handlers/handler_action_diagnostics.go b/internal/pkg/agent/application/actions/handlers/handler_action_diagnostics.go index 2a3d5768f22..f5a1553f946 100644 --- a/internal/pkg/agent/application/actions/handlers/handler_action_diagnostics.go +++ b/internal/pkg/agent/application/actions/handlers/handler_action_diagnostics.go @@ -338,7 +338,7 @@ func (h *Diagnostics) diagFile( cDiag []client.DiagnosticComponentResult, excludeEvents bool) (*os.File, int64, error) { - f, err := os.CreateTemp("", "elastic-agent-diagnostics") + f, err := os.CreateTemp(paths.TempDir(), "elastic-agent-diagnostics") if err != nil { return nil, 0, err }