-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(a11y): add focus to action story #1423
Conversation
Alright, so after taking a look I'm not sure what the best option is. Here are the options as I see it.
The difficulty is that the since we don't know when the popover is close (as we do with the color picker) we must have the user call Maybe the best approach is a helper hook in kibana to facilitate this process and wrap all actions in a way that is easy to replicate.
|
🎉 This PR is included in version 38.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Adding the ref change in the legend actions story to show focus being passed to the button once the popover is closed.
Oct-13-2021.15-24-55.mp4
Details
I opened elastic/kibana#115066 to have these changes in kibana, but this PR is just focused on the changes for this actions story.
Issues
Checklist
closes #123
,fixes #123
)dark
,light
,eui-dark
&eui-light