Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(heatmap): Sync cursor from xy charts to Heatmap #1721

Merged
merged 27 commits into from
Aug 4, 2022
Merged

feat(heatmap): Sync cursor from xy charts to Heatmap #1721

merged 27 commits into from
Aug 4, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jun 21, 2022

Summary

Cursor positions from xy charts are now synced with the Heatmap.

Screen.Recording.2022-06-21.at.14.01.07.mov

Details

This PR is a follow up of #1668. It converts the continuous external pointer events from xy charts into visible bands on the heatmap. It also highlights the grid cell when cursor is hovered.

Issues

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The :theme label has been added and the @elastic/eui-design team has been pinged when there are Theme API changes
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@qn895 qn895 added enhancement New feature or request :interactions Interactions related issue :heatmap Heatmap/Swimlane chart related issue labels Jun 21, 2022
@qn895 qn895 self-assigned this Jun 21, 2022
@qn895
Merge remote-tracking branch 'upstream/master' into cursor-sync-up-to…
d5810b5 
…-fix-linting

# Conflicts:
#	packages/charts/src/chart_types/heatmap/layout/types/viewmodel_types.ts
#	packages/charts/src/chart_types/heatmap/state/selectors/on_pointer_update_caller.ts
@qn895 qn895 force-pushed the cursor-sync-xy-charts-to-heatmap branch from 32ff05c to d5810b5 Compare June 21, 2022 19:45
@qn895 qn895 requested review from markov00 and nickofthyme June 21, 2022 19:45
@qn895 qn895 changed the title feat(heatmap): Sync cursor form xy charts to Heatmap feat(heatmap): Sync cursor from xy charts to Heatmap Jun 21, 2022
@markov00
Copy link
Member

buildkite update screenshots

@markov00 markov00 marked this pull request as ready for review July 28, 2022 15:26
@markov00 markov00 requested a review from monfera July 28, 2022 15:26
@markov00
Copy link
Member

markov00 commented Aug 3, 2022

buildkite update screenshots

@markov00
Copy link
Member

markov00 commented Aug 3, 2022

buildkite update screenshots

@markov00 markov00 merged commit 2b58e90 into elastic:master Aug 4, 2022
nickofthyme pushed a commit that referenced this pull request Aug 4, 2022
@semantic-release-bot
chore(release): 47.2.0 [skip ci]
12fb823 
# [47.2.0](v47.1.1...v47.2.0) (2022-08-04)

### Features

* **heatmap:** sync cursor between cartesian chart and heatmap ([#1721](#1721)) ([2b58e90](2b58e90))
* **text:** improved word wrap function ([#1761](#1761)) ([eaf0d59](eaf0d59))
* timeslip prototype added ([#1767](#1767)) ([b079766](b079766))
@flash1293 flash1293 mentioned this pull request Aug 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@markov00 markov00 Awaiting requested review from markov00

@monfera monfera Awaiting requested review from monfera

Assignees

@qn895 qn895

Labels
enhancement New feature or request :heatmap Heatmap/Swimlane chart related issue :interactions Interactions related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qn895 @markov00 @nickofthyme