Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config to enable apm-server #1593

Merged
merged 4 commits into from
Dec 13, 2023
Merged

add config to enable apm-server #1593

merged 4 commits into from
Dec 13, 2023

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Dec 12, 2023

Start and expose an APM Server under Elastic Agent when enabled in the config with:

stack.apm_server_enabled: true

@jsoriano jsoriano requested a review from a team December 12, 2023 16:45
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice approach to have an apm-server running here.

Could you also add an integration test?

{{ $apm_server_enabled := fact "apm_server_enabled" }}
{{ if eq $apm_server_enabled "true" }}
- "127.0.0.1:8200:8200"
{{ end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add this to the Fleet Server agent 👍 maybe at some point we can keep it always enabled and/or reuse it for actual performance monitoring of the testing framework.

Another option would be to create another agent, but this will probably bring unnecessary complexity.

internal/profile/_static/config.yml.example Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 👍

# Create an apm-server profile and use it
profile=with-apm-server
elastic-package profiles create -v ${profile}
elastic-package profiles use ${profile}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to use profiles for this 👍

@graphaelli graphaelli merged commit 9946fec into main Dec 13, 2023
4 checks passed
@graphaelli graphaelli deleted the with-apm-intake branch December 13, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants