-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add config to enable apm-server #1593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice approach to have an apm-server running here.
Could you also add an integration test?
{{ $apm_server_enabled := fact "apm_server_enabled" }} | ||
{{ if eq $apm_server_enabled "true" }} | ||
- "127.0.0.1:8200:8200" | ||
{{ end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to add this to the Fleet Server agent 👍 maybe at some point we can keep it always enabled and/or reuse it for actual performance monitoring of the testing framework.
Another option would be to create another agent, but this will probably bring unnecessary complexity.
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 👍
# Create an apm-server profile and use it | ||
profile=with-apm-server | ||
elastic-package profiles create -v ${profile} | ||
elastic-package profiles use ${profile} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to use profiles for this 👍
Start and expose an APM Server under Elastic Agent when enabled in the config with: