[Buildkite] Update buildkite scripts #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#8755 |
💚 Build Succeeded
cc @mrodm |
jsoriano
approved these changes
Dec 19, 2023
Comment on lines
+7
to
+9
| platform_type="$(uname)" | ||
| hw_type="$(uname -m)" | ||
| platform_type_lowercase="${platform_type,,}" |
There was a problem hiding this comment.
Nit. It looks a bit unexpected to me to call platform_type to the operating system. And platform_type is never used, so maybe we can reserve this name to the final form that we use.
Suggested change
| platform_type="$(uname)" | |
| hw_type="$(uname -m)" | |
| platform_type_lowercase="${platform_type,,}" | |
| uname_os_type="$(uname)" | |
| hardware_name="$(uname -m)" | |
| os_type="${uname_os_type,,}" |
sharbuz
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update buildkite scripts to get the platform and architecture in runtime.
Tested: